Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor_:remove part of node config for local pair sync #19826

Merged
merged 1 commit into from
May 7, 2024
Merged

refactor_:remove part of node config for local pair sync #19826

merged 1 commit into from
May 7, 2024

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Apr 29, 2024 •
edited
Loading

this is a continue work relate to PR, moved most of node config to backend. relate status-go PR

Testing notes

sync between:
iOS <-> iOS
Android <-> iOS
Android <-> Desktop
iOS <-> Desktop
should work as before.

Platforms

  • Android
  • iOS

status: ready

@qfrank qfrank self-assigned this Apr 29, 2024
@qfrank qfrank requested a review from cammellos April 29, 2024 09:21
@status-im-auto
Copy link
Member

status-im-auto commented Apr 29, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0376a3c #1 2024-04-29 09:26:33 ~5 min tests 📄log
✔️ 0376a3c #1 2024-04-29 09:29:04 ~7 min android-e2e 🤖apk 📲
✔️ 0376a3c #1 2024-04-29 09:29:27 ~7 min android 🤖apk 📲
✔️ 0376a3c #1 2024-04-29 09:34:20 ~12 min ios 📱ipa 📲
❌ c6322b4 #2 2024-05-07 11:21:39 ~3 min tests 📄log
✔️ c6322b4 #2 2024-05-07 11:25:03 ~7 min android 🤖apk 📲
✔️ c6322b4 #2 2024-05-07 11:27:07 ~9 min android-e2e 🤖apk 📲
✔️ c6322b4 #2 2024-05-07 11:28:58 ~11 min ios 📱ipa 📲
✔️ c6322b4 #3 2024-05-07 11:33:09 ~3 min tests 📄log

@status-im-auto
Copy link
Member

90% of end-end tests have passed

Total executed tests: 52
Failed tests: 3
Expected to fail tests: 2
Passed tests: 47

IDs of failed tests: 727230,727229,702844 

IDs of expected to fail tests: 703495,703503

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 1: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
    Device 1: `Text` is `0.04331 ETH` 

    critical/test_wallet.py:127: in test_wallet_send_asset_from_drawer
    self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender,
critical/test_wallet.py:98: in _check_balances_after_tx
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Eth amount in the receivers wallet is 0.0296 but should be 0.0297
E    Eth amount in the senders wallet is 0.0433 but should be 0.0432



    2. test_wallet_send_eth, id: 727229

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 2: Text is 0.0296 ETH 

    critical/test_wallet.py:112: in test_wallet_send_eth
    self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender,
critical/test_wallet.py:98: in _check_balances_after_tx
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Eth amount in the senders wallet is 0.0433 but should be 0.0432
E    Eth amount in the receivers wallet is 0.0296 but should be 0.0297



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Tap on found: SendMessageButton
    Device 1: Getting preview message for link: #11707 

    critical/chats/test_public_chat_browsing.py:587: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    message.wait_for_element(60)
../views/base_element.py:129: in wait_for_element
    raise TimeoutException(
 Device `1`: `PreviewMessage` by` xpath`: `//*[starts-with(@text,'https://github.com/status-im/status-mobile/pull/11707')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (47)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    @VolodLytvynenko VolodLytvynenko self-assigned this Apr 29, 2024
    @status-im-auto
    Copy link
    Member

    0% of end-end tests have passed

    Total executed tests: 1
Failed tests: 1
Expected to fail tests: 0
Passed tests: 0

    IDs of failed tests: 702844

    Failed tests (1)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Find `EmojisNumber` by `xpath`: `//*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView[2]`
    Device 2: Element EmojisNumber text is equal to 1 

    critical/chats/test_public_chat_browsing.py:613: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 No preview image is shown for https://github.com/status-im/status-mobile/pull/11707



    Device sessions

    @VolodLytvynenko
    Copy link
    Contributor

    hi @qfrank thank you for PR. No issues from my side. Ready to be merged

    @qfrank qfrank force-pushed the refactor/remove_node_config_for_local_pair_sync branch from 0376a3c to c6322b4 Compare May 7, 2024 11:17
    @qfrank qfrank merged commit 0c6bb61 into develop May 7, 2024
    6 checks passed
    @qfrank qfrank deleted the refactor/remove_node_config_for_local_pair_sync branch May 7, 2024 11:33
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @siddarthkay siddarthkay siddarthkay approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @cammellos cammellos Awaiting requested review from cammellos

    Assignees

    @qfrank qfrank

    @VolodLytvynenko VolodLytvynenko

    Labels
    request-manual-qa status-go Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @qfrank @status-im-auto @VolodLytvynenko @flexsurfer @siddarthkay