-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤝 [19834] Add dapp connection flow with a basic design #20204
Merged
shivekkhurana
merged 9 commits into
develop
from
19834-add-dapp-connection-flow-with-a-basic-design
Jun 4, 2024
Merged
🤝 [19834] Add dapp connection flow with a basic design #20204
shivekkhurana
merged 9 commits into
develop
from
19834-add-dapp-connection-flow-with-a-basic-design
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
shivekkhurana
added
the
wallet-connect: UI
Adding missing UI on top of the existing functionality and polishing it based on the descopeddesings
label
May 28, 2024
Jenkins BuildsClick to see older builds (23)
|
clauxx
reviewed
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing I noticed that once you press connect and it's successful, the modal doesn't disappear.
src/status_im/contexts/wallet/wallet_connect/session_proposal/style.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/wallet/wallet_connect/session_proposal/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/wallet/wallet_connect/session_proposal/view.cljs
Outdated
Show resolved
Hide resolved
@shivekkhurana added some more reviewers so it's not only our team reviewing 😅 EDIT: also no need to add the epic labels on PRs. They should be used only for issues |
clauxx
removed
the
wallet-connect: UI
Adding missing UI on top of the existing functionality and polishing it based on the descopeddesings
label
May 28, 2024
ulisesmac
reviewed
May 28, 2024
clauxx
reviewed
May 29, 2024
shivekkhurana
force-pushed
the
19834-add-dapp-connection-flow-with-a-basic-design
branch
2 times, most recently
from
June 3, 2024 12:49
70f399f
to
2b749c3
Compare
alwx
approved these changes
Jun 3, 2024
clauxx
approved these changes
Jun 3, 2024
shivekkhurana
force-pushed
the
19834-add-dapp-connection-flow-with-a-basic-design
branch
2 times, most recently
from
June 4, 2024 11:59
7f12425
to
126f2a9
Compare
shivekkhurana
force-pushed
the
19834-add-dapp-connection-flow-with-a-basic-design
branch
from
June 4, 2024 12:41
6f61ac9
to
adeb1a3
Compare
- IDK why, trying things out
- My handler was not being called because I wrote the code in a different QR scanner
- Hard coded the first account - The data item component doesn't support networks or accounts yet - The quo category component cannot show a data-item yet - Connected accept and decline button
shivekkhurana
force-pushed
the
19834-add-dapp-connection-flow-with-a-basic-design
branch
from
June 4, 2024 12:45
adeb1a3
to
64d1550
Compare
shivekkhurana
deleted the
19834-add-dapp-connection-flow-with-a-basic-design
branch
June 4, 2024 12:56
shivekkhurana
added a commit
that referenced
this pull request
Jun 4, 2024
This reverts commit 6ea39b5.
shivekkhurana
added a commit
that referenced
this pull request
Jun 4, 2024
shivekkhurana
restored the
19834-add-dapp-connection-flow-with-a-basic-design
branch
June 4, 2024 13:24
shivekkhurana
added a commit
that referenced
this pull request
Jun 5, 2024
…0325) * 🔳 QR on success not being called - IDK why, trying things out * 🙃 Stupid of me - My handler was not being called because I wrote the code in a different QR scanner * ✅ Approval screen taking shape * 🧹 Lint fix * 🎛️ Wallet connect session screen shows up - Hard coded the first account - The data item component doesn't support networks or accounts yet - The quo category component cannot show a data-item yet - Connected accept and decline button * 🧰 Fix review issues * 🔨 Fix lint * 🔧 Rename event and move dispatch * 🔧 Fix lint * 🎏 Add ff for wc scanner - Bring back missing event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an ongoing effort to implement wallet connect. This PR connects the existing methods to the universal qr code scanner. In case a valid Wallet Connect QR is scanned, the user gets an option to accept the connection.
In case the QR code is expired or the wallet connect version is not 2, the user gets a relevant error toast.
Review notes
Platforms
Areas that maybe impacted
Steps to test
status: ready