Feature: add wallet network settings to app settings #20254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (38)
|
mohsen-ghafouri
approved these changes
May 29, 2024
smohamedjavid
approved these changes
May 29, 2024
seanstrom
force-pushed
the
seanstrom/remove-network-settings-feature-flag
branch
from
0902d0c to
d6d3456
Compare
88% of end-end tests have passedNot executed tests (1)Failed tests (3)Click to expandClass TestActivityMultipleDevicePR:
Class TestWalletMultipleDevice:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Passed tests (45)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
86% of end-end tests have passedNot executed tests (1)Failed tests (3)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestWalletMultipleDevice:
Expected to fail tests (4)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (44)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
seanstrom
force-pushed
the
seanstrom/remove-network-settings-feature-flag
branch
from
d6d3456 to
fb28cf0
Compare
VolodLytvynenko
force-pushed
the
seanstrom/remove-network-settings-feature-flag
branch
from
fb28cf0 to
734e16e
Compare
|
Hi @seanstrom, I'm trying to understand how to achieve the "testnet is not available" status as shown in this design for Optimism. I encountered a toast message saying "the provider for the following chain is down: Arbitrum" even though Arbitrum is shown as active in the wallet settings. Should the network be displayed as "testnet is not available" when the provider is down? Logs: |
@VolodLytvynenko - No, The label On the other hand, the desktop app shows the 
|
@smohamedjavid Thank you for the clarification. @seanstrom PR is ready to be merged. Thank you for your work! |
|
@Francesca-G can you do a design review for this PR please? 🙏 |
seanstrom
force-pushed
the
seanstrom/remove-network-settings-feature-flag
branch
2 times, most recently
from
d599a9d to
7876f3d
Compare
|
@Francesca-G Oki doki 🧑🌾
|
Francesca-G
reviewed
Jun 4, 2024
There was a problem hiding this comment.
@seanstrom thank for addressing the issues!
the blur and the color issues seem to be fixed. nice job! ✨
the vertical spacing still needs some adjusting (Figma)
Feel free to create a separate issue for the blur as it's a recurring problem, thanks for pointing it out 🙏
seanstrom
force-pushed
the
seanstrom/remove-network-settings-feature-flag
branch
from
538e479 to
aea8276
Compare
|
@Francesca-G thanks for the feedback! |
seanstrom
force-pushed
the
seanstrom/remove-network-settings-feature-flag
branch
3 times, most recently
from
034984a to
66dfd02
Compare
seanstrom
force-pushed
the
seanstrom/remove-network-settings-feature-flag
branch
from
66dfd02 to
f05889d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19947
Summary
Review notes
Testing notes
.envfile withENABLE_ALERT_BANNER=1so the app will display the Testnet Mode banner.Platforms
Areas that maybe impacted
Functional
Steps to test
status: ready