-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(quo): update styles for account card variant missing keypair #20279
Conversation
Jenkins BuildsClick to see older builds (4)
|
@Francesca-G can you check this changes please? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the review with 2 minor changes to make :)
92b57e0
to
f87bf7c
Compare
f87bf7c
to
7d63963
Compare
thanks @Francesca-G - I updated to the review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now ✨
oh drat, @status-im/mobile-qa. I ran e2e tests but forgot to wait for the results. How should I proceed here? |
@J-Son89 no worries, we'll check the results once they are here and let you know if there is anything related to those changes. |
53% of end-end tests have passed
Not executed tests (1)Failed tests (21)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (3)Click to expandClass TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (27)Click to expandClass TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
0% of end-end tests have passed
Failed tests (21)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
|
@J-Son89 FYI: the failures here are not related to the PR 👌 |
Thanks @qoqobolo! |
fixes: #20251
This component mostly existed already. It only needed some minor UI adjustments to match the designs.
Light mode:
Screen.Recording.2024-05-30.at.17.04.45.mov
Dark Mode:
Screen.Recording.2024-05-30.at.17.05.35.mov
Manual QA can be skipped but a quick design check will be helpful