-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inability to input data while routes are loading #20298
Conversation
Jenkins Builds
|
maybe you could provide a quick overview in the description of what was causing the bug and how you addressed it? |
looks fine to me, but would be nice if @briansztamfater could give this a quick check 👌 |
(debounce/clear-all) | ||
(set-just-toggled-mode? false) | ||
(set-input-state #(controlled-input/add-character % c))))) | ||
:on-delete (fn [] | ||
(when-not loading-routes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-Son89 just removed this condition to allow typing while loading
86% of end-end tests have passed
Not executed tests (1)Failed tests (4)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (44)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
4f31581
to
546d0d1
Compare
100% of end-end tests have passed
Passed tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
|
Hi @OmarBasem thank you for PR. No issues from my side. PR is ready to be merged |
fixes: #20230
Summary
This PR fixes inability to update input while routes are loading
Demo
Screen_Recording_20240603_092834_Status.mp4