-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#19734] feat: share saved address QR #20315
Conversation
Jenkins BuildsClick to see older builds (8)
|
dd8009f
to
41b8404
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff 🙌
Left a couple comments about some styles 🎨
src/status_im/contexts/settings/wallet/saved_addresses/sheets/share_address/view.cljs
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/saved_addresses/sheets/share_address/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/saved_addresses/sheets/share_address/view.cljs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀 @mohsen-ghafouri
src/status_im/contexts/settings/wallet/saved_addresses/sheets/share_address/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/saved_addresses/sheets/share_address/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/saved_addresses/sheets/share_address/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/saved_addresses/sheets/share_address/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/saved_addresses/sheets/share_address/view.cljs
Show resolved
Hide resolved
41b8404
to
f6df329
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
53% of end-end tests have passed
Not executed tests (1)Failed tests (21)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (3)Click to expandClass TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (27)Click to expandClass TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
@status-im/mobile-qa could you please check result? this screen is still behind feature flag |
@mohsen-ghafouri thanks for the PR. Failed e2e are not PR related, this is a result of problems on Waku side. Ready for merge. |
f6df329
to
4838b91
Compare
4838b91
to
290a866
Compare
fixes #19734
Summary
Implement the screen to show the QR code that can be shared
Areas that maybe impacted
Steps to test
Result
Simulator.Screen.Recording.-.iPhone.13.-.2024-06-03.at.21.38.18.mp4
status: ready