chore: bump status-go with filter improvements #20369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (24)
|
|
On android, my peer stats screen is empty (i enabled light client). |
Hey @fryorcraken! This is a UI issue on Android. Peer stats data is not visible in light mode. Switch appearance to Dark mode and peer stats will be visible for you. See video below. telegram-cloud-document-2-5408879549687550850.mp4 |
80% of end-end tests have passedNot executed tests (1)Failed tests (6)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Passed tests (41)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
Class TestDeepLinksOneDevice:
|
86% of end-end tests have passedNot executed tests (1)Failed tests (4)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (44)Click to expandClass TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
|
22% of end-end tests have passedNot executed tests (1)Failed tests (39)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Expected to fail tests (1)Click to expandClass TestWalletOneDevice:
Passed tests (11)Click to expandClass TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
@chaitanyaprem hey! Recent testrun failed because messages are not delivered in chats. ISSUE 1 Messages are not delivered in chatsSteps:
Actual result: messages are not delivered User_A_sender.log User A sending messages https://app.eu-central-1.saucelabs.com/tests/03f7f9be92084779901d8a2375174023?auth=5d114754ef23a17d91469fe83aa22813#95 User B not receiving messages https://app.eu-central-1.saucelabs.com/tests/59a110f76b8f49dd9289d20e2583fcdd?auth=6a4cd0d0dc19c74aba0aa15d7bbdaaf6#126 |
25% of end-end tests have passedNot executed tests (1)Failed tests (35)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (13)Click to expandClass TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
61% of end-end tests have passedNot executed tests (1)Failed tests (16)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletMultipleDevice:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (4)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (31)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
43% of end-end tests have passedNot executed tests (1)Failed tests (27)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (22)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
|
@chaitanyaprem Unfortunately tests are still failing. Here are failure examples from the last testrun: 1. Community is failed to be fetchedSteps:
Actual result: community is not fetched 2. Contact request is not delivered to receiverSteps:
Actual result: User_A_contact_request_sender.log Contact request is not delivered to User B. |
12% of end-end tests have passedNot executed tests (1)Failed tests (42)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletMultipleDevice:
Expected to fail tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (6)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestWalletOneDevice:
|
43% of end-end tests have passedNot executed tests (1)Failed tests (27)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (22)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
@chaitanyaprem According to the latest e2e results the main root cause of the failures is delay in delivering contact requests. I have reproduced the issue manually, see the details below: Contact request (CR) signals are delivered with delaySteps:
Actual result: User B appeared in User's A contact list only after User A performs re-login User_A_CR_sender_IOS.zip cr_delivery_delay.mp4Expected result: User A should appear in User's B contact list once User A accepts User's B contact request. |
82% of end-end tests have passedNot executed tests (1)Failed tests (5)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (4)Click to expandClass TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (42)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
|
chaitanyaprem
force-pushed
the
status-go/filter-improvements
branch
from
267683f to
5989685
Compare
84% of end-end tests have passedNot executed tests (1)Failed tests (4)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestWalletMultipleDevice:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (43)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
|
@chaitanyaprem thank you for the PR! I have completed testing. Here is a summary of most noticeable issues that I have faced during testing:
I would assume that those issues could be related to current implementation in which we are using only fleet nodes. So, I propose not to block this PR anymore and merge it. We will have another round of testing once connection to other running desktop instances will be fixed, please ping me up once the fix is ready. IMPORATNT: if you gonna merge mobile PR as well - please do not forget to disable light client as default. |
Thanks a lot for the testing and summarizing the results! if i am not wrong, these are issues related to store node queries and not with Filter.
Sure, that would anyways be required.
Not sure if i should merge it. What is the general procedure? |
I am not facing issues on relay mode, in develop builds for instance. So I assume it is related to light client.
If there were no changes on mobile side (except enabling light client as default) - then you can just close mobile PR. We will get your go changes next time when go version will be bumped in mobile develop. |
Odd though, because these doesn't seem to have anything to do with filter.
Yep, no other changes in mobile so will not merge this one. Will only merge status-go PR. |
|
Closing this PR as changes are mainly in status-go and this is used only for testing. |
But couldn't the fact that we are not connecting to desktop instances cause delay in fetching different kinds of data? I think we need to re-check it once this issue will be fixed. If the issue remains - then we will need to investigate more deeply. |
Nope, fleet nodes are supposed to be the fastest way to fetch data, unless if it is something to be fetched from desktop instance of community owner..but i am not sure of the flows there yet. |
Okay, so this is really suspicious as I see a big difference between fetching in develop build and PR. Anyway, I will focus on re-testing this in future PRs related to light client. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issues noticed in lightClient using Waku-Filter protocol.
Summary
Improved lightClient functionality especially fixing issues around Waku-Filter protocol usage and optimizing how filter subscriptions are managed and Filter ping occurs with service node.
Still some optimizations and additional work is pending wrt light client reliability, but this PR brings Filter to a hopefully decent stage(without any major issues) before proceeding with further changes.
Note that if you are subscribed to status community, there would be a lot of filter subscriptions. This still needs optimization which is pending. Anyways, number of subscriptions would help test nwaku node as well to handle soo may :)
Note that to reduce issues with lightClient(by not connecting to other desktop instances), this build only uses fleet nodes and does not do any discovery via peerExchange.Relevant status-go PR status-im/status-go#4665
Review notes
Testing notes (To be updated)
Note to enable debug logs while testing.
Enable lightClient from Advanced Settings@chaitanyaprem has updated PR so lightClient is Enabled by defaultIn case of any issue please report along with debug logs via DM or as a comment in this PR itself.
Platforms
Areas that maybe impacted
Functional
Non-functional
None
status: for dogfooding only