fix: ensure the key pair action button opens bottom-sheet inside key pairs and accounts #20611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanstrom
commented
Jul 1, 2024
Comment on lines
104
to
105
| :on-press #(when (= action :selector) (on-press)) | ||
| :pointer-events :box-only} |
There was a problem hiding this comment.
Here I'm removing this :pointer-events prop because when it's set to box-only it will not allow the pointer events to hit reach the "..." menu button inside the key-pair component.
Perhaps we need to pass a configuration prop for this if we need to ensure it's box-only sometimes, thoughts?
There was a problem hiding this comment.
not sure why we need it at all 🤔
There was a problem hiding this comment.
I'm not sure why it's needed in the first place 🤔 .
There was a problem hiding this comment.
I added the box-only because when we use it for keypair selection, other non important areas are pressable and make hard to select the proper keypair.
@seanstrom Probably we should handle the :box-only according to the variant displayed
There was a problem hiding this comment.
@ulisesmac Oh I see, so this is meant to make it simpler to press the key-pair, in that case I'll try using (when (= action :selector) :box-only) for that prop. Thank you for clarifying 🙏
There was a problem hiding this comment.
@ulisesmac - I suppose the on-press should be handled by the selector (it receives the on-change prop), not the parent. WDYT? This would help us prevent these pointer event tricks.
status-mobile/src/quo/components/wallet/keypair/view.cljs
Lines 52 to 56 in 8aa1cad
There was a problem hiding this comment.
@smohamedjavid I'm not sure, but I think the intent is to make the key-pair component easier to select during the key-pair selection step. If we put the on-press handler on the selector, that would make the target smaller for selecting a key-pair when ideally it would be the entire key-pair UI.
Jenkins BuildsClick to see older builds (8)
|
mohsen-ghafouri
approved these changes
Jul 1, 2024
smohamedjavid
approved these changes
Jul 2, 2024
Comment on lines
104
to
105
| :on-press #(when (= action :selector) (on-press)) | ||
| :pointer-events :box-only} |
There was a problem hiding this comment.
I'm not sure why it's needed in the first place 🤔 .
seanstrom
force-pushed
the
seanstrom/fix-key-pair-accounts-menu-button
branch
2 times, most recently
from
7b37094 to
a7cb467
Compare
49% of end-end tests have passedFailed tests (24)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletMultipleDevice:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Passed tests (25)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
Hey @seanstrom ! Your fix looks good on both platforms. |
seanstrom
force-pushed
the
seanstrom/fix-key-pair-accounts-menu-button
branch
from
a7cb467 to
c4bddf5
Compare
yevh-berdnyk
pushed a commit
that referenced
this pull request
Jul 14, 2024
…#20611) This change attempts to only to override the default `pointer-events` behaviour for the `quo/keypair` component when the component uses the `selector` action. Now when the `quo/keypair` component is rendered with a selector, only the top-level view of the component will be pressable. And when the `quo/keypair` component is rendered without a selector it will allow for the children of the component to be pressable too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20609
Summary
Platforms
Areas that maybe impacted
Functional
Steps to test
Screen capture after changes
Screen.Recording.2024-07-04.at.11.51.45.mov
status: ready