feat: use 1 content-topic for all chats within a community (not to merge) #21407

chaitanyaprem · 2024-10-09T10:32:40Z

Summary

This PR is mainly to dogfood underlying changes made in status-go.

Reference PR status-im/status-go#5864 which has details.

This PR uses single content-topic for all community chats to send messages. It still receives messages on all existing content-topics used by previous versions in order to maintain compatibility.

Details of the discussion are available https://forum.vac.dev/t/status-communities-review-and-proposed-usage-of-waku-content-topics/335/29

Testing notes

Platforms

Android
iOS

Areas that maybe impacted

Community chats and control flows

Functional

public chats
all community chats and control flows (channel creation, updation, deletion, permissions change, user add, user kick etc)
new account

Steps to test

This PR would require complete testing of communities in relay and light modes.
It would also require to be tested for compacibility with older version of the code.
Best to check all admin functions as well using this new code
We also need to validate if community admin is using older code and a member is using new code there are no incompatibilites.
All chats and community flows such as add member, remove member, add channel, delete channel, change permissions to channels etc

Risk

Described potential risks and worst case scenarios.

Tick one:

Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
High risk: QA team MUST perform additional testing in the specified affected areas before merging.

-->

status-im-auto · 2024-10-09T10:38:32Z

Jenkins Builds

Click to see older builds (4)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`a0930bf`	#1	2024-10-09 10:38:32	~5 min	`tests`	📄`log`
✔️	`a0930bf`	#1	2024-10-09 10:41:35	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`a0930bf`	#1	2024-10-09 10:42:45	~9 min	`android`	🤖`apk` 📲
✔️	`a0930bf`	#1	2024-10-09 10:43:21	~10 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`e57f206`	#3	2024-10-17 08:05:44	~4 min	`tests`	📄`log`
✔️	`e57f206`	#3	2024-10-17 08:08:02	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`e57f206`	#3	2024-10-17 08:10:12	~9 min	`android`	🤖`apk` 📲
✔️	`e57f206`	#3	2024-10-17 08:11:29	~10 min	`ios`	📱`ipa` 📲

✔️	`66733bc`	#4	2024-12-12 06:17:30	~6 min	`tests`	📄`log`
✔️	`66733bc`	#4	2024-12-12 06:19:19	~8 min	`ios`	📱`ipa` 📲
✔️	`66733bc`	#4	2024-12-12 06:21:22	~10 min	`android-e2e`	🤖`apk` 📲
✔️	`66733bc`	#4	2024-12-12 06:22:57	~12 min	`android`	🤖`apk` 📲

churik · 2024-10-09T12:53:56Z

Blocking it until 2.31 is cut

churik · 2024-11-04T16:10:58Z

@chaitanyaprem
when status-go code is ready, please update it here and move to E2E tests column.
Besides, I suppose we need to check it with desktop based on the same status-go, so please mention me and @anastasiyaig in status-im/status-go#5864
Thanks!

chaitanyaprem · 2024-12-12T06:11:54Z

@churik this code is ready from status-go side and has been validated and dogfooded by devs.
This can be taken up for 2.33.

status-im-auto · 2024-12-12T06:16:50Z

0% of end-end tests have passed

Total executed tests: 8
Failed tests: 8
Expected to fail tests: 0
Passed tests: 0

IDs of failed tests: 727230,727231,702745,702742,740490,727229,703133,702843

Failed tests (8)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843

Device 2: Wait for element `Button` for max 30s and click when it is available
Device 1: Wait for element `Button` for max 30s and click when it is available

Test setup failed: critical/chats/test_public_chat_browsing.py:309: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True}),
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:243: in create_user
    self.maybe_later_button.wait_and_click()
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Button by accessibility id:`maybe-later-button` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Test setup failed: critical/test_wallet.py:27: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:267: in recover_access self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`maybe-later-button` is not found on the screen after wait_for_visibility_of_element
2. test_wallet_send_eth, id: 727229
Device 1: Wait for element `Button` for max 30s and click when it is available Device 2: Wait for element `Button` for max 30s and click when it is available Test setup failed: critical/test_wallet.py:27: in prepare_devices self.loop.run_until_complete( /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete return future.result() __init__.py:52: in run_in_parallel returns.append(await k) /usr/lib/python3.10/concurrent/futures/thread.py:58: in run result = self.fn(self.args, *self.kwargs) ../views/sign_in_view.py:267: in recover_access self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`maybe-later-button` is not found on the screen after wait_for_visibility_of_element

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

Device 2: Wait for element Button for max 30s and click when it is available
Device 1: Wait for element Button for max 30s and click when it is available

Test setup failed: critical/chats/test_1_1_public_chats.py:23: in prepare_devices
    self.loop.run_until_complete(run_in_parallel(((self.device_1.create_user, {'enable_notifications': True}),
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:52: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/sign_in_view.py:243: in create_user
    self.maybe_later_button.wait_and_click()
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Button by accessibility id:`maybe-later-button` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device 1: Find `Button` by `accessibility id`: `new-to-status-button` Device 1: Wait for element `Button` for max 30s and click when it is available Test setup failed: critical/chats/test_public_chat_browsing.py:25: in prepare_devices self.home = self.sign_in.create_user() ../views/sign_in_view.py:243: in create_user self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`maybe-later-button` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs
2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Test setup failed: critical/chats/test_public_chat_browsing.py:25: in prepare_devices self.home = self.sign_in.create_user() ../views/sign_in_view.py:243: in create_user self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`maybe-later-button` is not found on the screen after wait_for_visibility_of_element

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Test setup failed: critical/test_wallet.py:207: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase']) ../views/sign_in_view.py:267: in recover_access self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`maybe-later-button` is not found on the screen after wait_for_visibility_of_element
2. test_wallet_balance_mainnet, id: 740490
Device 1: Find `Button` by `accessibility id`: `new-to-status-button` Device 1: Wait for element `Button` for max 30s and click when it is available Test setup failed: critical/test_wallet.py:207: in prepare_devices self.sign_in_view.recover_access(passphrase=self.sender['passphrase']) ../views/sign_in_view.py:267: in recover_access self.maybe_later_button.wait_and_click() ../views/base_element.py:100: in wait_and_click self.wait_for_visibility_of_element(sec) ../views/base_element.py:147: in wait_for_visibility_of_element raise TimeoutException( Device 1: Button by accessibility id:`maybe-later-button` is not found on the screen after wait_for_visibility_of_element

flexsurfer added status-go waku All issues relating to the Status Waku integration. labels Oct 9, 2024

churik added the blocked label Oct 9, 2024

chaitanyaprem force-pushed the feat/community-content-topic branch 2 times, most recently from 519e4fb to e57f206 Compare October 17, 2024 08:00

flexsurfer assigned chaitanyaprem Oct 29, 2024

churik removed the blocked label Nov 4, 2024

feat: use 1 content-topic for all chats within a community

66733bc

chaitanyaprem force-pushed the feat/community-content-topic branch from e57f206 to 66733bc Compare December 12, 2024 06:10

ilmotta mentioned this pull request Dec 16, 2024

feat_: use a single content-topic for all community chats status-im/status-go#5864

Open

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use 1 content-topic for all chats within a community (not to merge) #21407

feat: use 1 content-topic for all chats within a community (not to merge) #21407

chaitanyaprem commented Oct 9, 2024

status-im-auto commented Oct 9, 2024 •

edited

Loading

churik commented Oct 9, 2024

churik commented Nov 4, 2024

chaitanyaprem commented Dec 12, 2024

status-im-auto commented Dec 12, 2024

Class TestCommunityMultipleDeviceMerged:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

feat: use 1 content-topic for all chats within a community (not to merge) #21407

Are you sure you want to change the base?

feat: use 1 content-topic for all chats within a community (not to merge) #21407

Conversation

chaitanyaprem commented Oct 9, 2024

Summary

Testing notes

Platforms

Areas that maybe impacted

Functional

Steps to test

Risk

status-im-auto commented Oct 9, 2024 • edited Loading

Jenkins Builds

churik commented Oct 9, 2024

churik commented Nov 4, 2024

chaitanyaprem commented Dec 12, 2024

status-im-auto commented Dec 12, 2024

0% of end-end tests have passed

Failed tests (8)

Class TestCommunityMultipleDeviceMerged:

Class TestWalletMultipleDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

status-im-auto commented Oct 9, 2024 •

edited

Loading