Upgrade react native to 0.53.3 #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
reviewed
Feb 21, 2018
| "stream-browserify": "1.0.0", | ||
| "string_decoder": "0.10.31", | ||
| "timers-browserify": "1.4.2", | ||
| "tty-browserify": "0.0.0", | ||
| "url": "0.10.3", | ||
| "vm-browserify": "0.0.4", | ||
| "web3": "github:status-im/web3.js#status-develop", | ||
| "rn-snoopy": "github:status-im/rn-snoopy" | ||
| "web3": "github:status-im/web3.js#status-develop" |
There was a problem hiding this comment.
Can we use exact version match here?
flexsurfer
requested changes
Feb 21, 2018
env/dev/env/android/main.cljs
Outdated
| @@ -1,7 +1,7 @@ | |||
| (ns ^:figwheel-no-load env.android.main | |||
| (:require [reagent.core :as r] | |||
| [status-im.android.core :as core] | |||
| [figwheel.client :as figwheel :include-macros true] | |||
| [figwheel.client :as fw] | |||
There was a problem hiding this comment.
we are using full names , figwheel was correct
env/dev/env/ios/main.cljs
Outdated
| @@ -3,10 +3,9 @@ | |||
| [re-frisk-remote.core :as rr] | |||
| [status-im.ios.core :as core] | |||
| [status-im.utils.handlers :as utils.handlers] | |||
| [figwheel.client :as figwheel :include-macros true] | |||
| [figwheel.client :as fw] | |||
There was a problem hiding this comment.
we are using full names , figwheel was correct
| @@ -0,0 +1,9 @@ | |||
| // workaround for react-native-vector-icons | |||
There was a problem hiding this comment.
could you elaborate why we need this?
There was a problem hiding this comment.
Apparently some changes in Metro's file resolving behavior surfaced packaging issues in react-native-vector-icons. This file works around this by ignoring the offending files.
A longer explanation here.
There was a problem hiding this comment.
I understand the files ignored are test fixtures, so there should be no harm in ignoring them in our builds.
|
@flexsurfer Thanks for the feedback! Pushed fixes for the figwheel alias. To provide some background, changes in both files were the result of Ideally, there would be some way to keep the code separate so re-natal can cleanly patch when upgrading - maybe something to look into in the future (not that it is too important, considering the frequency of upgrading). |
|
@voxlet What is |
|
@jeluard Looks like it simply copies over the files in
|
|
Yes in our case it's probably useless. Our |
flexsurfer
approved these changes
Feb 21, 2018
|
@jeluard Agreed, I ended up reverting most of Digging around the re-natal script turned out to be good learning experience, though! Demystified a lot of what's going on behind the scenes, and what it actually takes to use CLJS on React Native. |
jeluard
approved these changes
Feb 21, 2018
Automated test results:test_network_switch:white_check_mark::Test Steps & Error message:test_contact_profile_view:white_check_mark::Test Steps & Error message:test_browse_link_entering_url_in_dapp_view:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_now:white_check_mark::Test Steps & Error message:test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:test_send_stt_from_wallet_via_enter_recipient_address:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_transaction_send_command_one_to_one_chat:white_check_mark::Test Steps & Error message:test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_one_to_one_chat_messages_and_delete_chat:white_check_mark::Test Steps & Error message:test_group_chat_messages:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:x:Test Steps & Error message:
test_send_eth_to_request_in_group_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:test_public_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message: |
|
I've tested the whole app and the only thing I found is that the "Type your password" and "Confirm" hints are not fully visible:
To reproduce:
@voxlet could you please check it? |
Automated test results:test_contact_profile_view:x:Test Steps & Error message:
test_browse_link_entering_url_in_dapp_view:white_check_mark::Test Steps & Error message:test_network_switch:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_now:white_check_mark::Test Steps & Error message:test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_send_stt_from_wallet_via_enter_recipient_address:white_check_mark::Test Steps & Error message:test_transaction_send_command_one_to_one_chat:white_check_mark::Test Steps & Error message:test_public_chat:white_check_mark::Test Steps & Error message:test_one_to_one_chat_messages_and_delete_chat:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:x:Test Steps & Error message:
test_group_chat_messages:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_group_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message: |
lukaszfryc
previously requested changes
Feb 23, 2018
There was a problem hiding this comment.
@voxlet there is a small issue with a hint in input fields. Please check my latest comment.
Automated test results:test_network_switch:white_check_mark::Test Steps & Error message:test_browse_link_entering_url_in_dapp_view:white_check_mark::Test Steps & Error message:test_contact_profile_view:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_now:white_check_mark::Test Steps & Error message:test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:white_check_mark::Test Steps & Error message:test_public_chat:white_check_mark::Test Steps & Error message:test_one_to_one_chat_messages_and_delete_chat:white_check_mark::Test Steps & Error message:test_send_stt_from_wallet_via_enter_recipient_address:white_check_mark::Test Steps & Error message:test_transaction_send_command_one_to_one_chat:x:Test Steps & Error message:
test_group_chat_messages:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_group_chat:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message: |
|
@lukaszfryc Fixed, though this is probably more a workaround than a proper fix. |
lukaszfryc
dismissed
their stale review
My review was not related to the code changes
Automated test results:test_transaction_send_command_one_to_one_chat:x:Test Steps & Error message:
test_contact_profile_view:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_now:x:Test Steps & Error message:
test_public_chat:x:Test Steps & Error message:
test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_one_to_one_chat_messages_and_delete_chat:x:Test Steps & Error message:
test_group_chat_messages:white_check_mark::Test Steps & Error message:test_transaction_send_command_wrong_password:x:Test Steps & Error message:
test_network_switch:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:white_check_mark::Test Steps & Error message:test_browse_link_entering_url_in_dapp_view:white_check_mark::Test Steps & Error message:test_send_stt_from_wallet_via_enter_recipient_address:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_group_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message: |
|
@voxlet Please resolve conflict |
voxlet
force-pushed
the
feature/upgrade-react-native-#3377
branch
from
1727b89
to
8137068
Compare
|
@jeluard rebased to current develop |
|
@voxlet Also please squash your commits! |
voxlet
force-pushed
the
feature/upgrade-react-native-#3377
branch
from
8137068
to
f4fc2d3
Compare
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
flexsurfer
force-pushed
the
feature/upgrade-react-native-#3377
branch
from
f4fc2d3
to
35e8278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3377
Summary:
Upgrades:
Review notes:
Includes workarounds for react-native-vector-icons (or rather, Metro) and FlatList keyExtractor.
As a side note, we could probably safely upgrade to re-frame 0.10.2 -> 0.10.4 which is what Re-Natal 0.8.1 is on.
Steps to test:
rm -rf node_modulesgroup-transactions-by-date, which also fails in develop, though I suspect the tests do not actually test React to begin with)status: ready