[ISSUE #1858] Improved wallet main screen refresh #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeluard
force-pushed
the
bug/#1858
branch
3 times, most recently
from
03774a2
to
f24f268
Compare
jeluard
changed the title
goranjovic
approved these changes
Feb 22, 2018
alwx
approved these changes
Feb 22, 2018
Automated test results:test_network_switch:white_check_mark::Test Steps & Error message:test_one_to_one_chat_messages_and_delete_chat:x:Test Steps & Error message:
test_group_chat_messages:x:Test Steps & Error message:
test_transaction_send_command_wrong_password:x:Test Steps & Error message:
test_send_eth_to_request_in_one_to_one_chat:x:Test Steps & Error message:
test_send_eth_to_request_in_group_chat:x:Test Steps & Error message:
test_public_chat:x:Test Steps & Error message:test_send_eth_from_wallet_sign_now:white_check_mark::Test Steps & Error message:test_send_stt_from_wallet_via_enter_recipient_address:white_check_mark::Test Steps & Error message:test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_transaction_send_command_one_to_one_chat:x:Test Steps & Error message:
test_transaction_send_command_group_chat:x:Test Steps & Error message:
test_contact_profile_view:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message:test_browse_link_entering_url_in_dapp_view:white_check_mark::Test Steps & Error message: |
|
@jeluard is there anything we can do with this "jumping" on iOS (wallet main screen)? I do see this jumping (pulling breaks for a second) when pulling the screen down. |
|
@asemiankevich What kind of jumping is it? |
|
I made a video of this jumping. It’s not a critical bug, just to achieve super smooth experience. Good job anyway! https://www.dropbox.com/s/cqjkrmc7pxx0mx2/Video%2024-02-2018%2C%2009%2049%2040.mov?dl=0 Also small issue: when I’m swiping this screen up I could see a blue background under white. It should ve white all the time. Maybe we can just expand height of a white rectangle?
|
|
Sure will look at the jumping.
I noticed the blue part but could not find a workaround to it. It was either that or having the spinning area with a blue backround.
|
jeluard
force-pushed
the
bug/#1858
branch
2 times, most recently
from
fee71c1
to
6dffa68
Compare
|
@asemiankevich Made changes, please take a look! |
100% of end-end tests have passedPassed tests (16)Click to expand
|
|
@jeluard I dont see spinner anymore when pull-to-refresh on ios :( as well as no assets shown on android http://prntscr.com/iurg8g |
|
@jeluard layout of the screen works much better! thanks! |
|
@asemiankevich Pushed some changes |
|
@jeluard no spinner still and jumping is back in latest build |
jeluard
force-pushed
the
bug/#1858
branch
3 times, most recently
from
5810532
to
026dac1
Compare
|
@asemiankevich Can't get both spinner and no jump on iOS. I sugest we merge this as it's much better than develop and bounty to get the spinner. |
|
so can we have previous build then? With smooth scrolling but without spinner . @denis-sharypin |
|
Yes I restored it. |
|
then please merge it and create a bounty for jumping (if you dont mind) |
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1858
fixes #2819
Summary:
Make sure the whole main wallet screen is refreshable, not individual lists.
Steps to test:
status: ready