WIP - [FIX #4327] Migrate to react-native-firebase #4716

rasom · 2018-06-12T10:35:29Z

this is just rebased #4446
i will close this PR after testing (just don't want to touch original codebase until we sure that i rebased everything correctly)

status: ready

pedropombeiro

Found just a merge issue, but compared with my own rebase and all else looks the same.

pedropombeiro · 2018-06-12T11:31:53Z

android/app/build.gradle

@@ -211,7 +212,7 @@ dependencies {
    implementation "com.android.support:appcompat-v7:26.1.0"
    // Force using exact RN version instead of relying on gradle dependency resolution
    // https://docs.gradle.org/current/userguide/introduction_dependency_management.html#sec:dependency_resolution
-    compile ("com.facebook.react:react-native:0.55.4") { force = true }  // From node_modules
+    implementation ("com.facebook.react:react-native:0.53.3") { force = true }  // From node_modules


Looks like a merge issue, this should stay at 0.55.4 right?

fixed, thanks

pedropombeiro · 2018-06-12T11:43:33Z

android/app/build.gradle

@@ -212,7 +212,7 @@ dependencies {
    implementation "com.android.support:appcompat-v7:26.1.0"
    // Force using exact RN version instead of relying on gradle dependency resolution
    // https://docs.gradle.org/current/userguide/introduction_dependency_management.html#sec:dependency_resolution
-    implementation ("com.facebook.react:react-native:0.53.3") { force = true }  // From node_modules
+    compile ("com.facebook.react:react-native:0.55.4") { force = true }  // From node_modules


Don't we want to use implementation though? From original PR: #4446 (comment)

status-comment-bot · 2018-06-12T12:10:23Z

branch PR-4716:
apk uploaded to https://i.diawi.com/QNa7nD
ipa uploaded to https://i.diawi.com/SLibSU

Install - Diawi - Development and In-house Apps Wireless Installation

pedropombeiro

Looks good, now it's just a question of testing (which I imagine will be good since I tested recently with a similar rebase) and also having your opinion on the actual changes of this PR, to see if we're not introducing something unnecessary to the actual issue.

status-comment-bot · 2018-06-12T12:36:13Z

branch PR-4716:
apk uploaded to https://i.diawi.com/24UWzX
ipa uploaded to https://i.diawi.com/vVeava

Install - Diawi - Development and In-house Apps Wireless Installation

rasom · 2018-06-13T09:13:17Z

android/build.gradle

@@ -6,8 +6,8 @@ buildscript {
        jcenter()
    }
    dependencies {
-        classpath 'com.android.tools.build:gradle:3.0.1'
-        classpath 'com.google.gms:google-services:3.0.0'
+        classpath 'com.android.tools.build:gradle:3.1.2'


not sure that this change is necessary, but not a problem

https://rnfirebase.io/docs/v4.2.x/installation/android

it is necessary

rasom · 2018-06-13T09:13:41Z

android/gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip


shouldn't be required as well

Can we remove it?

https://rnfirebase.io/docs/v4.2.x/installation/android it seems this change is necessary

rasom · 2018-06-13T09:14:20Z

@pombeirp looks fine for me

pedropombeiro · 2018-06-13T12:02:41Z

Thanks @rasom!

jeluard · 2018-06-13T12:09:30Z

android/app/build.gradle

@@ -211,7 +212,7 @@ dependencies {
    implementation "com.android.support:appcompat-v7:26.1.0"
    // Force using exact RN version instead of relying on gradle dependency resolution
    // https://docs.gradle.org/current/userguide/introduction_dependency_management.html#sec:dependency_resolution
-    compile ("com.facebook.react:react-native:0.55.4") { force = true }  // From node_modules


Previous comment applies to the use of compile I believe. @dmitryn Can you comment?

jeluard · 2018-06-13T12:10:02Z

android/app/src/main/AndroidManifest.xml

@@ -9,6 +9,8 @@
    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
    <uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
    <uses-permission android:name="android.permission.READ_PROFILE" />
+    <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />


Do we want those?

https://rnfirebase.io/docs/v4.2.x/notifications/android#Update-Android-Manifest

jeluard · 2018-06-13T12:10:30Z

android/gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip


Can we remove it?

jeluard · 2018-06-13T12:11:17Z

ios/Podfile.lock


-COCOAPODS: 1.3.1
+COCOAPODS: 1.5.3


Is this required?

Firebase deps require higher version of cocoapods

jeluard · 2018-06-13T12:11:57Z

ios/Podfile.lock

+  - nanopb/decode (0.3.8)
+  - nanopb/encode (0.3.8)
+  - Protobuf (3.5.0)
+  - React (0.55.4):


Why changes to versions here?

@jeluard this file is autogenerated, hard to answer tbh. I suppose it's related to different cocoapods version

status-comment-bot · 2018-06-13T15:47:49Z

branch PR-4716:
apk uploaded to https://i.diawi.com/PLoewG
ipa uploaded to https://i.diawi.com/2EtGH3

Install - Diawi - Development and In-house Apps Wireless Installation

status-comment-bot · 2018-06-15T17:58:48Z

branch PR-4716:
apk uploaded to https://i.diawi.com/X26pnP
ipa uploaded to https://i.diawi.com/ZevUaH

Install - Diawi - Development and In-house Apps Wireless Installation

statustestbot · 2018-06-15T18:20:46Z

76% of end-end tests have passed

Total executed tests: 29
Failed tests: 7
Passed tests: 22

Failed tests (7)

Click to expand

1. test_send_transaction_from_daap
Waiting 350 seconds for funds Waiting 360 seconds for funds `E Failed: Balance is not changed during 360 seconds, funds were not received!` Device sessions: Device 1
2. test_faucet_console_command
EthAssetText is 0 Waiting 300 seconds for ETH update `E Failed: Balance is not changed during 300 seconds!` Device sessions: Device 1
3. test_send_eth_to_request_from_wallet
Wait for SignInPhraseText Looking for DoneButton `E selenium.common.exceptions.NoSuchElementException: Message: 'DoneButton' is not found on screen, using: 'accessibility id:done-button'` Device sessions: Device 1 Device 2
4. test_delete_1_1_chat
Tap on GotItButton Looking for full text: '0.00001' `E selenium.common.exceptions.TimeoutException: Message: 'BaseElement' is not found on screen, using: 'xpath://*[@text="0.00001"]', during '60' seconds` Device sessions: Device 1
5. test_transaction_send_command_one_to_one_chat
Waiting 290 seconds for donation Waiting 300 seconds for donation `E Failed: Donation was not received during 300 seconds!` Device sessions: Device 1
6. test_send_eth_to_request_in_one_to_one_chat
Wait for SignInPhraseText Looking for DoneButton `E selenium.common.exceptions.NoSuchElementException: Message: 'DoneButton' is not found on screen, using: 'accessibility id:done-button'` Device sessions: Device 1 Device 2
7. test_set_up_wallet
Waiting 290 seconds for donation Waiting 300 seconds for donation `E Failed: Donation was not received during 300 seconds!` Device sessions: Device 1

Passed tests (22)

Click to expand

1. test_sign_transaction_twice
Device sessions: Device 1
2. test_swipe_and_delete_1_1_chat
Device sessions: Device 1
3. test_one_to_one_chat_messages
Device sessions: Device 1 Device 2
4. test_copy_and_paste_messages
Device sessions: Device 1
5. test_username_and_profile_picture_in_chats
Device sessions: Device 1 Device 2
6. test_send_eth_from_wallet_sign_now
Device sessions: Device 1
7. test_open_transaction_on_etherscan
Device sessions: Device 1
8. test_incorrect_password
Device sessions: Device 1
9. test_backup_seed_phrase_and_recover_account
Device sessions: Device 1
10. test_offline_messaging_1_1_chat
Device sessions: Device 1 Device 2
11. test_contact_profile_view
Device sessions: Device 1
12. test_public_chat
Device sessions: Device 1 Device 2
13. test_public_chat_management
Device sessions: Device 1 Device 2
14. test_network_switch
Device sessions: Device 1
15. test_wallet_error_messages
Device sessions: Device 1
16. test_browse_link_entering_url_in_dapp_view
Device sessions: Device 1
17. test_transaction_send_command_wrong_password
Device sessions: Device 1
18. test_profile_picture
Device sessions: Device 1
19. test_switch_users
Device sessions: Device 1
20. test_send_stt_from_wallet_via_enter_recipient_address
Device sessions: Device 1
21. test_qr_code_and_its_value
Device sessions: Device 1
22. test_sign_message_from_daap
Device sessions: Device 1

status-comment-bot · 2018-06-16T00:49:50Z

branch PR-4716:
apk uploaded to https://i.diawi.com/grFQsa
ipa uploaded to https://i.diawi.com/R8HaMa

Install - Diawi - Development and In-house Apps Wireless Installation

statustestbot · 2018-06-18T16:00:06Z

100% of end-end tests have passed

Total executed tests: 29
Failed tests: 0
Passed tests: 29

Passed tests (29)

Click to expand

1. test_sign_transaction_twice
Device sessions: Device 1
2. test_swipe_and_delete_1_1_chat
Device sessions: Device 1
3. test_one_to_one_chat_messages
Device sessions: Device 1 Device 2
4. test_copy_and_paste_messages
Device sessions: Device 1
5. test_send_transaction_from_daap
Device sessions: Device 1
6. test_faucet_console_command
Device sessions: Device 1
7. test_username_and_profile_picture_in_chats
Device sessions: Device 1 Device 2
8. test_send_eth_from_wallet_sign_now
Device sessions: Device 1
9. test_open_transaction_on_etherscan
Device sessions: Device 1
10. test_send_eth_to_request_from_wallet
Device sessions: Device 1 Device 2
11. test_incorrect_password
Device sessions: Device 1
12. test_backup_seed_phrase_and_recover_account
Device sessions: Device 1
13. test_offline_messaging_1_1_chat
Device sessions: Device 1 Device 2
14. test_contact_profile_view
Device sessions: Device 1
15. test_public_chat
Device sessions: Device 1 Device 2
16. test_public_chat_management
Device sessions: Device 1 Device 2
17. test_network_switch
Device sessions: Device 1
18. test_delete_1_1_chat
Device sessions: Device 1
19. test_wallet_error_messages
Device sessions: Device 1
20. test_transaction_send_command_one_to_one_chat
Device sessions: Device 1
21. test_browse_link_entering_url_in_dapp_view
Device sessions: Device 1
22. test_transaction_send_command_wrong_password
Device sessions: Device 1
23. test_send_eth_to_request_in_one_to_one_chat
Device sessions: Device 1 Device 2
24. test_profile_picture
Device sessions: Device 1
25. test_switch_users
Device sessions: Device 1
26. test_set_up_wallet
Device sessions: Device 1
27. test_send_stt_from_wallet_via_enter_recipient_address
Device sessions: Device 1
28. test_qr_code_and_its_value
Device sessions: Device 1
29. test_sign_message_from_daap
Device sessions: Device 1

status-comment-bot · 2018-06-19T07:32:20Z

branch PR-4716:
apk uploaded to https://i.diawi.com/ddAUkb
ipa uploaded to https://i.diawi.com/FsHYhN

Install - Diawi - Development and In-house Apps Wireless Installation

status-comment-bot · 2018-06-19T09:16:30Z

branch PR-4716:
apk uploaded to https://i.diawi.com/QDhKTT
ipa uploaded to https://i.diawi.com/Z3uh1H

statustestbot · 2018-06-19T12:38:35Z

93% of end-end tests have passed

Total executed tests: 29
Failed tests: 2
Passed tests: 27

Failed tests (2)

Click to expand

1. test_offline_messaging_1_1_chat
Looking for ShareMyContactKeyButton Tap on ShareMyContactKeyButton `E TypeError: 'NoneType' object is not subscriptable` Device sessions: Device 1 Device 2
2. test_send_eth_to_request_in_one_to_one_chat
Wait for HomeButton Looking for IHaveAccountButton `E selenium.common.exceptions.NoSuchElementException: Message: 'IHaveAccountButton' is not found on screen, using: 'xpath://android.widget.TextView[@text='I ALREADY HAVE AN ACCOUNT']'` Device sessions: Device 1 Device 2

Passed tests (27)

Click to expand

1. test_sign_transaction_twice
Device sessions: Device 1
2. test_swipe_and_delete_1_1_chat
Device sessions: Device 1
3. test_one_to_one_chat_messages
Device sessions: Device 1 Device 2
4. test_copy_and_paste_messages
Device sessions: Device 1
5. test_send_transaction_from_daap
Device sessions: Device 1
6. test_faucet_console_command
Device sessions: Device 1
7. test_username_and_profile_picture_in_chats
Device sessions: Device 1 Device 2
8. test_send_eth_from_wallet_sign_now
Device sessions: Device 1
9. test_open_transaction_on_etherscan
Device sessions: Device 1
10. test_send_eth_to_request_from_wallet
Device sessions: Device 1 Device 2
11. test_incorrect_password
Device sessions: Device 1
12. test_backup_seed_phrase_and_recover_account
Device sessions: Device 1
13. test_contact_profile_view
Device sessions: Device 1
14. test_public_chat
Device sessions: Device 1 Device 2
15. test_public_chat_management
Device sessions: Device 1 Device 2
16. test_network_switch
Device sessions: Device 1
17. test_delete_1_1_chat
Device sessions: Device 1
18. test_wallet_error_messages
Device sessions: Device 1
19. test_transaction_send_command_one_to_one_chat
Device sessions: Device 1
20. test_browse_link_entering_url_in_dapp_view
Device sessions: Device 1
21. test_transaction_send_command_wrong_password
Device sessions: Device 1
22. test_profile_picture
Device sessions: Device 1
23. test_switch_users
Device sessions: Device 1
24. test_set_up_wallet
Device sessions: Device 1
25. test_send_stt_from_wallet_via_enter_recipient_address
Device sessions: Device 1
26. test_qr_code_and_its_value
Device sessions: Device 1
27. test_sign_message_from_daap
Device sessions: Device 1

pedropombeiro · 2018-06-19T14:48:24Z

This PR implies an upgrade to RN 0.55 which contains a regression: facebook/react-native#19339 #4829

We need to wait for a fix before merging this.

status-comment-bot · 2018-06-20T01:27:05Z

branch PR-4716:
apk uploaded to https://i.diawi.com/RrwPFj
ipa uploaded to https://i.diawi.com/njeQNm

Install - Diawi - Development and In-house Apps Wireless Installation

rasom · 2018-08-13T05:24:36Z

@pombeirp @annadanchenko is this task still relevant o we can just close PR?

pedropombeiro · 2018-08-13T08:39:46Z

It looks like we're already on RN 0.55 and react-native-firebase, so I'd say we can close this.

pedropombeiro suggested changes Jun 12, 2018

View reviewed changes

pedropombeiro reviewed Jun 12, 2018

View reviewed changes

pedropombeiro approved these changes Jun 12, 2018

View reviewed changes

rasom self-assigned this Jun 13, 2018

rasom commented Jun 13, 2018

View reviewed changes

pedropombeiro requested a review from jeluard June 13, 2018 12:02

jeluard reviewed Jun 13, 2018

View reviewed changes

rasom force-pushed the feature/react-native-firebase-migration-4327-rebased branch from be03c23 to 1f73c25 Compare June 13, 2018 15:15

yenda approved these changes Jun 15, 2018

View reviewed changes

lukaszfryc assigned lukaszfryc and unassigned lukaszfryc Jun 18, 2018

asemiankevich self-assigned this Jun 19, 2018

rasom added 2 commits June 19, 2018 11:33

[FIX #4327] Migrate to react-native-firebase

8371b77

revert some changes

40e55c8

rasom force-pushed the feature/react-native-firebase-migration-4327-rebased branch from 1f73c25 to 40e55c8 Compare June 19, 2018 08:33

asemiankevich assigned annadanchenko and unassigned asemiankevich Jun 19, 2018

pedropombeiro changed the title ~~[FIX #4327] Migrate to react-native-firebase~~ WIP - [FIX #4327] Migrate to react-native-firebase Jun 19, 2018

pedropombeiro closed this Aug 13, 2018

pedropombeiro deleted the feature/react-native-firebase-migration-4327-rebased branch August 13, 2018 08:40


		COCOAPODS: 1.3.1
		COCOAPODS: 1.5.3

WIP - [FIX #4327] Migrate to react-native-firebase #4716

WIP - [FIX #4327] Migrate to react-native-firebase #4716

Conversation

rasom commented Jun 12, 2018 • edited Loading

pedropombeiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

status-comment-bot commented Jun 12, 2018 • edited by ghost Loading

pedropombeiro left a comment

Choose a reason for hiding this comment

status-comment-bot commented Jun 12, 2018 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rasom commented Jun 13, 2018

pedropombeiro commented Jun 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

status-comment-bot commented Jun 13, 2018 • edited by ghost Loading

status-comment-bot commented Jun 15, 2018 • edited by ghost Loading

statustestbot commented Jun 15, 2018

76% of end-end tests have passed

Failed tests (7)

Passed tests (22)

status-comment-bot commented Jun 16, 2018 • edited by ghost Loading

statustestbot commented Jun 18, 2018

100% of end-end tests have passed

Passed tests (29)

status-comment-bot commented Jun 19, 2018 • edited by ghost Loading

status-comment-bot commented Jun 19, 2018

statustestbot commented Jun 19, 2018

93% of end-end tests have passed

Failed tests (2)

Passed tests (27)

pedropombeiro commented Jun 19, 2018 • edited Loading

status-comment-bot commented Jun 20, 2018 • edited by ghost Loading

rasom commented Aug 13, 2018

pedropombeiro commented Aug 13, 2018

rasom commented Jun 12, 2018 •

edited

Loading

status-comment-bot commented Jun 12, 2018 •

edited by ghost

Loading

status-comment-bot commented Jun 12, 2018 •

edited by ghost

Loading

status-comment-bot commented Jun 13, 2018 •

edited by ghost

Loading

status-comment-bot commented Jun 15, 2018 •

edited by ghost

Loading

status-comment-bot commented Jun 16, 2018 •

edited by ghost

Loading

status-comment-bot commented Jun 19, 2018 •

edited by ghost

Loading

pedropombeiro commented Jun 19, 2018 •

edited

Loading

status-comment-bot commented Jun 20, 2018 •

edited by ghost

Loading