[#6596] Add a component to access local camera #7328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (87)
|
Jenkins Builds
|
Jenkins Builds
|
tbenr
force-pushed
the
Add-a-component-to-access-local-camera
branch
3 times, most recently
from
d55fb38
to
91b33dc
Compare
|
@tbenr Great start! Looks nice! |
|
@jeluard we are on the way to reach that! :) |
tbenr
force-pushed
the
Add-a-component-to-access-local-camera
branch
2 times, most recently
from
82ba8e5
to
463e04c
Compare
tbenr
changed the title
tbenr
force-pushed
the
Add-a-component-to-access-local-camera
branch
from
463e04c
to
bb3b384
Compare
|
there are 2 things that can be improved:
|
jeluard
requested review from
flexsurfer,
jeluard,
cammellos,
dmitryn and
goranjovic
jeluard
approved these changes
Jan 29, 2019
flexsurfer
approved these changes
Jan 29, 2019
|
@tbenr When you get a chance, can you comment on @flexsurfer points? |
|
@jeluard @flexsurfer sure, i'm currently away for work. Tomorrow I should have the time to answer and apply changes |
tbenr
force-pushed
the
Add-a-component-to-access-local-camera
branch
from
bb3b384
to
945fb50
Compare
tbenr
force-pushed
the
Add-a-component-to-access-local-camera
branch
from
945fb50
to
d979ea0
Compare
|
@tbenr Build is failing. I can see at least one warning: |
|
@jeluard I'll check ASAP, locally I don't get this error.. |
|
@Serhy I fixed both issues. |
98% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (57)Click to expand |
100% of end-end tests have passedPassed tests (1) |
|
@tbenr right, both issues are fixed. Taking as expected behaviour of User Profile image selection: Open Status -> Profile -> tap EDIT -> choose userpic from device Gallery. In a case of selecting video format file we "ignore" it, - i.e. nothing is updated on userpic. PreconditionsRecord video with default device Camera app Reproduction:
|
|
ok, let me implement some filtering on peek.. or at least ignore\notify to user. |
|
@tbenr Right! Maybe there could be a fixed set of approved mime type that could be overridden by the event user? |
tbenr
force-pushed
the
Add-a-component-to-access-local-camera
branch
from
0fbfc24
to
255b39b
Compare
|
@tbenr Thanks again ! We can leave video for another bounty I guess .. :D |
|
@jeluard 👍 also 'cause I'd like to concentrate on map component which is driving me crazy :-D |
98% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (57)Click to expand |
|
Looks good to me! Thanks a lot, @tbenr for fixes and for your contribution! |
|
🎉 |
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
jeluard
force-pushed
the
Add-a-component-to-access-local-camera
branch
from
255b39b
to
51f6a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6596
camera/qr-codeevent which starts camera to scan qr codes. It manages success scan, user cancel and permission denied.camera/picturewill be the event which should let the user choose toextension example:
https://status-im.github.io/pluto/try.html?hash=QmTu4fjZmNEa6PSRpPPz9qoxq24uK9XQnJFZQg3LQ7avv4
https://get.status.im/extension/ipfs@QmTu4fjZmNEa6PSRpPPz9qoxq24uK9XQnJFZQg3LQ7avv4