Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7933] fix - joining public chat with messages throws error #7936

Merged
merged 1 commit into from
Apr 19, 2019
Merged

[#7933] fix - joining public chat with messages throws error #7936

merged 1 commit into from
Apr 19, 2019

Conversation

bitsikka
Copy link
Contributor

@bitsikka bitsikka commented Apr 8, 2019 •
edited by 0xc1c4da
Loading

fixes #7933

tested on android-avd

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Apr 8, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (19)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e9aeed1 #1 2019-04-08 14:51:34 ~16 min macos 📦 dmg
✔️ e9aeed1 #1 2019-04-08 14:52:40 ~18 min ios 📦 ipa
✔️ e9aeed1 #1 2019-04-08 15:23:24 ~48 min linux 📦 App
✔️ e9aeed1 #1 2019-04-08 15:25:14 ~50 min windows 📦 exe
✔️ 4ec8ab5 #2 2019-04-10 14:21:35 ~19 min macos 📦 dmg
✔️ 4ec8ab5 #2 2019-04-10 14:21:35 ~19 min ios 📦 ipa
✔️ 4ec8ab5 #2 2019-04-10 14:21:48 ~19 min linux 📦 App
✔️ 4ec8ab5 #2 2019-04-10 14:23:09 ~20 min windows 📦 exe
✔️ 4ec8ab5 #2 2019-04-10 14:26:38 ~24 min android 📦 apk
✔️ a60514c #3 2019-04-12 09:30:18 ~29 min macos 📦 dmg
✔️ a60514c #3 2019-04-12 09:43:46 ~43 min android 📦 apk
✔️ a60514c #3 2019-04-12 09:54:45 ~54 min windows 📦 exe
✔️ a60514c #3 2019-04-12 09:55:53 ~55 min linux 📦 App
✔️ af8d74e #5 2019-04-15 20:29:58 ~15 min macos 📦 dmg
✔️ af8d74e #5 2019-04-15 20:31:26 ~17 min android-e2e 📦 apk
✔️ af8d74e #5 2019-04-15 20:31:47 ~17 min android 📦 apk
✔️ af8d74e #5 2019-04-15 20:36:26 ~22 min linux 📦 App
✔️ af8d74e #5 2019-04-15 20:36:49 ~22 min windows 📦 exe
✔️ af8d74e #5 2019-04-15 20:38:04 ~23 min ios 📦 ipa
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c4989de #6 2019-04-17 07:02:45 ~15 min macos 📦 dmg
✔️ c4989de #6 2019-04-17 07:04:47 ~17 min android 📦 apk
✔️ c4989de #6 2019-04-17 07:09:31 ~22 min ios 📦 ipa
✔️ c4989de #6 2019-04-17 07:11:55 ~24 min linux 📦 App
✔️ c4989de #6 2019-04-17 07:13:52 ~26 min windows 📦 exe
✔️ c4989de #6 2019-04-17 07:16:20 ~29 min android-e2e 📦 apk
❌ 8482ea5 #7 2019-04-19 10:17:02 ~15 min android-e2e 📄 log
❌ 8482ea5 #7 2019-04-19 10:17:02 ~15 min android 📄 log
✔️ 8482ea5 #7 2019-04-19 10:17:18 ~15 min macos 📦 dmg
✔️ 8482ea5 #7 2019-04-19 10:19:24 ~17 min linux 📦 App
✔️ 8482ea5 #7 2019-04-19 10:20:08 ~18 min windows 📦 exe
✔️ 8482ea5 #7 2019-04-19 10:27:10 ~25 min ios 📦 ipa

@bitsikka bitsikka mentioned this pull request Apr 16, 2019
Closed
@bitsikka
Copy link
Contributor Author

rebased to latest develop

@churik churik self-assigned this Apr 17, 2019
@statustestbot
Copy link

87% of end-end tests have passed

Total executed tests: 47
Failed tests: 6
Passed tests: 41

Failed tests (6)

Click to expand
1. test_send_transaction_from_daap

Device 1: Type 'simpledapp.eth' to EnterUrlEditbox
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'AssetsButton' is not found on the screen

Device sessions

2. test_deploy_contract_from_daap

Device 1: Type 'simpledapp.eth' to EnterUrlEditbox
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'AssetsButton' is not found on the screen

Device sessions

3. test_logcat_send_transaction_from_daap

Device 1: Type 'simpledapp.eth' to EnterUrlEditbox
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'AssetsButton' is not found on the screen

Device sessions

4. test_logcat_sign_message_from_daap

Device 1: Type 'simpledapp.eth' to EnterUrlEditbox
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'AssetsButton' is not found on the screen

Device sessions

5. test_send_two_transactions_one_after_another_in_dapp

Device 1: Type 'simpledapp.eth' to EnterUrlEditbox
Device 1: Tap 'Confirm' on native keyboard

Device 1: 'AssetsButton' is not found on the screen

Device sessions

6. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for PlusButton
Device 1: Wait for PlusButton

Donation was not received during 300 seconds!

Device sessions

Passed tests (41)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_request_and_receive_tokens_in_1_1_chat
Device sessions

4. test_public_chat_messaging
Device sessions

5. test_password_in_logcat_sign_in
Device sessions

6. test_text_message_1_1_chat
Device sessions

7. test_add_to_contacts
Device sessions

8. test_sign_typed_message (TestRail link is not found)
Device sessions

9. test_unread_messages_counter_1_1_chat
Device sessions

10. test_send_message_in_group_chat
Device sessions

11. test_logcat_send_transaction_from_wallet
Device sessions

12. test_send_token_with_7_decimals
Device sessions

13. test_modify_transaction_fee_values
Device sessions

14. test_send_eth_from_wallet_to_address
Device sessions

15. test_manage_assets
Device sessions

16. test_logcat_send_transaction_in_1_1_chat
Device sessions

17. test_request_and_receive_eth_in_1_1_chat
Device sessions

18. test_swipe_to_delete_public_chat
Device sessions

19. test_send_emoji
Device sessions

20. test_search_chat_on_home
Device sessions

21. test_logcat_recovering_account
Device sessions

22. test_messaging_in_different_networks
Device sessions

23. test_send_tokens_in_1_1_chat
Device sessions

24. test_network_mismatch_for_send_request_commands
Device sessions

25. test_swipe_to_delete_1_1_chat
Device sessions

26. test_switch_users_and_add_new_account
Device sessions

27. test_send_stt_from_wallet
Device sessions

28. test_send_eth_in_1_1_chat
Device sessions

29. test_login_with_new_account
Device sessions

30. test_send_eth_from_wallet_to_contact
Device sessions

31. test_add_contact_from_public_chat
Device sessions

32. test_password_in_logcat_creating_account
Device sessions

33. test_backup_recovery_phrase
Device sessions

34. test_offline_status
Device sessions

35. test_open_google_com_via_open_dapp
Device sessions

36. test_unread_messages_counter_public_chat
Device sessions

37. test_sign_message_from_daap
Device sessions

38. test_user_can_remove_profile_picture
Device sessions

39. test_share_contact_code_and_wallet_address
Device sessions

40. test_request_eth_in_wallet
Device sessions

41. test_refresh_button_browsing_app_webview
Device sessions

@churik
Copy link
Member

churik commented Apr 17, 2019

Checked on Android 8 (joining all type of chats, fetching messages from offline mode) and IOS 11.
No more console.error in logs.
One more thank you @bitsikka for noticing and fixing it.
Failed teats are not related to PR, so ready to merge.

@bitsikka @rasom
[#7933] fix - joining public chat with messages throws error
8482ea5 
[#7933] fix - joining public chat with messages throws error
@rasom rasom merged commit 8482ea5 into status-im:develop Apr 19, 2019
@bitsikka bitsikka deleted the fix/#7933 branch April 19, 2019 10:56
@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2019
Closed
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasom rasom rasom approved these changes

@yenda yenda yenda approved these changes

@mandrigin mandrigin mandrigin approved these changes

Assignees

@churik churik

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

joining public chat with messages throws error
7 participants
@bitsikka @status-im-auto @statustestbot @churik @mandrigin @yenda @rasom