Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7911 #7894] delete account and logout after keycard reset #7937

Merged
merged 1 commit into from
May 8, 2019
Merged

[#7911 #7894] delete account and logout after keycard reset #7937

merged 1 commit into from
May 8, 2019

Conversation

dmitryn
Copy link
Contributor

@dmitryn dmitryn commented Apr 8, 2019 •
edited by 0xc1c4da
Loading

fixes #7894
fixes #7911

Summary:

Delete account and logout after keycard reset.

status: ready

@dmitryn dmitryn added the keycard label Apr 8, 2019
@dmitryn dmitryn self-assigned this Apr 8, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Apr 8, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (66)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 39a30d4 #1 2019-04-08 15:20:18 ~14 min macos 📦 dmg
❌ 39a30d4 #1 2019-04-08 15:23:59 ~18 min ios 📄 log
✔️ 39a30d4 #1 2019-04-08 15:34:14 ~28 min android 📦 apk
✔️ 39a30d4 #1 2019-04-08 15:42:27 ~36 min android-e2e 📦 apk
✔️ 39a30d4 #1 2019-04-08 15:44:00 ~38 min windows 📦 exe
✔️ 7efa71d #2 2019-04-08 16:23:59 ~14 min macos 📦 dmg
✔️ 7efa71d #2 2019-04-08 16:26:55 ~17 min ios 📦 ipa
✔️ 7efa71d #2 2019-04-08 16:29:02 ~19 min windows 📦 exe
✔️ 7efa71d #2 2019-04-08 16:33:09 ~23 min linux 📦 App
✔️ 7efa71d #2 2019-04-08 16:38:24 ~29 min android-e2e 📦 apk
✔️ 7efa71d #3 2019-04-09 08:33:12 ~24 min android 📦 apk
✔️ 91e791f #3 2019-04-09 12:41:51 ~18 min macos 📦 dmg
✔️ 91e791f #3 2019-04-09 12:43:53 ~20 min ios 📦 ipa
✔️ 91e791f #3 2019-04-09 12:44:13 ~20 min windows 📦 exe
✔️ 91e791f #3 2019-04-09 12:44:45 ~20 min linux 📦 App
✔️ 91e791f #3 2019-04-09 12:49:16 ~25 min android-e2e 📦 apk
✔️ 91e791f #4 2019-04-09 12:50:35 ~26 min android 📦 apk
✔️ 24282f0 #4 2019-04-11 13:31:15 ~16 min macos 📦 dmg
✔️ 24282f0 #4 2019-04-11 13:35:47 ~20 min ios 📦 ipa
✔️ 24282f0 #4 2019-04-11 14:01:58 ~47 min linux 📦 App
✔️ 24282f0 #4 2019-04-11 14:07:15 ~52 min windows 📦 exe
✔️ 24282f0 #5 2019-04-11 14:14:41 ~59 min android 📦 apk
✔️ 24282f0 #4 2019-04-11 14:18:05 ~1 hr 3 min android-e2e 📦 apk
❌ b7e7838 #5 2019-04-11 15:27:55 ~4 min ios 📄 log
✔️ b7e7838 #5 2019-04-11 15:37:27 ~14 min macos 📦 dmg
❌ b7e7838 #6 2019-04-11 15:50:21 ~32 sec ios 📄 log
✔️ b7e7838 #6 2019-04-11 16:05:39 ~42 min android 📦 apk
✔️ b7e7838 #5 2019-04-11 16:07:46 ~44 min linux 📦 App
✔️ b7e7838 #5 2019-04-11 16:08:53 ~45 min windows 📦 exe
✔️ b2b6afb #6 2019-04-11 17:36:18 ~12 min macos 📦 dmg
✔️ b2b6afb #6 2019-04-11 17:45:15 ~21 min android-e2e 📦 apk
✔️ b2b6afb #7 2019-04-11 17:49:11 ~25 min ios 📦 ipa
✔️ b2b6afb #7 2019-04-11 17:50:41 ~27 min android 📦 apk
✔️ b2b6afb #6 2019-04-11 17:51:00 ~27 min windows 📦 exe
✔️ b2b6afb #6 2019-04-11 17:55:00 ~31 min linux 📦 App
✔️ 018fc09 #7 2019-04-13 04:42:46 ~14 min macos 📦 dmg
✔️ 018fc09 #8 2019-04-13 04:48:17 ~19 min android 📦 apk
✔️ 018fc09 #7 2019-04-13 04:48:51 ~20 min android-e2e 📦 apk
✔️ 018fc09 #7 2019-04-13 04:50:01 ~21 min linux 📦 App
✔️ 018fc09 #7 2019-04-13 04:50:10 ~21 min windows 📦 exe
✔️ 018fc09 #8 2019-04-13 04:53:50 ~25 min ios 📦 ipa
✔️ 886d4a1 #8 2019-04-23 16:15:01 ~13 min null 📦 dmg
✔️ 886d4a1 #8 2019-04-23 16:21:13 ~19 min null 📦 exe
✔️ 886d4a1 #8 2019-04-23 16:21:28 ~20 min null 📦 App
✔️ 886d4a1 #9 2019-04-23 16:23:36 ~22 min null 📦 ipa
✔️ 41831f9 #9 2019-04-23 16:38:58 ~13 min null 📦 dmg
✔️ 41831f9 #9 2019-04-23 16:45:13 ~19 min null 📦 App
✔️ 41831f9 #9 2019-04-23 16:45:59 ~20 min null 📦 exe
✔️ 41831f9 #9 2019-04-23 16:46:51 ~21 min null-e2e 📦 apk
✔️ 41831f9 #10 2019-04-23 16:47:23 ~21 min null 📦 ipa
✔️ 1d0abdb #10 2019-04-29 06:58:19 ~19 min null 📦 App
✔️ 1d0abdb #10 2019-04-29 06:58:58 ~20 min null 📦 exe
✔️ 1d0abdb #11 2019-04-29 07:03:27 ~24 min null 📦 ipa
✔️ 1d0abdb #11 2019-04-29 07:06:40 ~28 min null 📦 apk
✔️ 1155afa #11 2019-04-29 19:16:58 ~14 min macos 📦 dmg
✔️ 1155afa #11 2019-04-29 19:19:17 ~16 min linux 📦 App
✔️ 1155afa #11 2019-04-29 19:19:24 ~16 min windows 📦 exe
✔️ 1155afa #12 2019-04-29 19:19:30 ~17 min android 📦 apk
✔️ 1155afa #12 2019-04-29 19:27:27 ~25 min android-e2e 📦 apk
✔️ 1155afa #12 2019-04-29 19:28:36 ~26 min ios 📦 ipa
✔️ 143b744 #12 2019-05-03 10:23:17 ~15 min macos 📦 dmg
✔️ 143b744 #12 2019-05-03 10:23:20 ~15 min linux 📦 App
✔️ 143b744 #12 2019-05-03 10:31:29 ~23 min windows 📦 exe
✔️ 143b744 #13 2019-05-03 10:31:47 ~24 min android 📦 apk
✔️ 143b744 #13 2019-05-03 10:31:58 ~24 min android-e2e 📦 apk
✔️ 143b744 #13 2019-05-03 10:32:50 ~25 min ios 📦 ipa
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ b477faf #15 2019-05-06 12:45:22 ~12 min ios 📄 log
✔️ b477faf #15 2019-05-06 13:02:39 ~29 min android-e2e 📦 apk
✔️ b477faf #15 2019-05-06 13:03:06 ~30 min android 📦 apk
✔️ b477faf #14 2019-05-06 13:03:24 ~30 min macos 📦 dmg
✔️ b477faf #14 2019-05-06 13:13:03 ~40 min linux 📦 App
✔️ b477faf #14 2019-05-06 13:13:51 ~40 min windows 📦 exe
✔️ b477faf #16 2019-05-08 08:35:32 ~26 min ios 📦 ipa
✔️ 311f6de #15 2019-05-08 11:52:00 ~18 min macos 📦 dmg
✔️ 311f6de #16 2019-05-08 11:52:20 ~18 min android-e2e 📦 apk
✔️ 311f6de #16 2019-05-08 11:52:34 ~18 min android 📦 apk
✔️ 311f6de #15 2019-05-08 11:55:25 ~21 min linux 📦 App
✔️ 311f6de #15 2019-05-08 11:56:22 ~22 min windows 📦 exe
✔️ 311f6de #17 2019-05-08 11:57:37 ~23 min ios 📦 ipa

@dmitryn dmitryn force-pushed the bug/7911-logout-after-reset branch from 39a30d4 to 7efa71d Compare April 8, 2019 16:09
@churik churik self-assigned this Apr 9, 2019
@churik
Copy link
Member

churik commented Apr 9, 2019

@dmitryn

1) After logout bottom panel is visible and can't login and use app again until manual restart

Steps:

  • create account with keycard
  • login with keycard
  • logout
  • try to login
    After logout bottom panel is visible, an user is redirected to account list instead of "sign in" screen for last used account:
    sdfsfd
    At attempt to login user is redirected to endless spinner:
    weer
    and when try to switch to profile application asks for PIN again.
    The same happening after reset card when you have one account - bottom panel is visible (it shouldn't)
    Expected: after logout can login and use app, no bottom panel is shown after logout

@dmitryn dmitryn force-pushed the bug/7911-logout-after-reset branch from 7efa71d to 91e791f Compare April 9, 2019 12:23
@dmitryn
Copy link
Contributor Author

dmitryn commented Apr 9, 2019

If i remove intro from profile-stack, i get:

There is no route defined for key intro.
04-09 16:06:28.657  4899  4947 E ReactNativeJS: Must be one of: 'currency-settings','show-extension','about-app','blocked-users-list','network-settings','fleet-settings','edit-mailserver','reset-card','hardwallet-success','qr-scanner','ma
nage-dapps-permissions','my-profile','log-level-settings','dapps-permissions','hardwallet-connect','keycard-settings','offline-messaging-settings','network-details','contacts-list','hardwallet-setup','installations','edit-network','enter-
pin','profile-photo-capture','mobile-network-settings','bootnodes-settings','tribute-to-talk','help-center','hardwallet-authentication-method','backup-seed','edit-extension','edit-bootnode','extensions-settings'

@rasom do you have an idea how to fix it? We need to navigate from profile to intro screen after deleting the account (in case app has no other accounts)

@rasom
Copy link
Contributor

rasom commented Apr 11, 2019

@dmitryn will check later today

@dmitryn dmitryn force-pushed the bug/7911-logout-after-reset branch from 91e791f to 24282f0 Compare April 11, 2019 13:14
@rasom
Copy link
Contributor

rasom commented Apr 11, 2019

@dmitryn should be fixed now.

The problem is that we didn't add :intro screen to stack if app was opened with existing accounts, and when you removed the last one that screen couldn't be found.

@dmitryn
Copy link
Contributor Author

dmitryn commented Apr 11, 2019

@rasom "There is no route" error is still there.

You can reproduce this way:

@dmitryn
Copy link
Contributor Author

dmitryn commented Apr 11, 2019

@rasom please hold on, i haven't applied your commit. Let me test again.

@dmitryn
Copy link
Contributor Author

dmitryn commented Apr 11, 2019

@rasom it works fine, thank you!

@rasom
Copy link
Contributor

rasom commented Apr 11, 2019

huh, I was a bit puzzled already. Good! :)

@dmitryn
Copy link
Contributor Author

dmitryn commented Apr 11, 2019

@churik please take a look once builds will be ready

@asemiankevich
Copy link
Contributor

@dmitryn

  1. user is asked for PIN again after codes screen is shown
  2. error is shown when PIN is entered, exit closes the app

image

Here is the video https://drive.google.com/open?id=10Eu1C9c7lUVeCG5P-NgD6wKPlcHR4eL7

@statustestbot
Copy link

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 3
Passed tests: 45

Failed tests (3)

Click to expand
1. test_send_two_transactions_one_after_another_in_dapp

Device 1: Tap on GotItButton
Device 1: Looking for an element by text: 'Sign transaction'

Second send transaction screen did not appear!

Device sessions

2. test_share_contact_code_and_wallet_address

Device 1: Tap 'Confirm' on native keyboard
Device 1: Looking for an element by text part: '0x027dF3E23BD0F857bF53D7Bdd936E933626286e0'

Can't share address

Device sessions

3. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for SendTransactionButton
Device 1: Wait for BackupRecoveryPhrase

'Backup your Recovery phrase' option is not shown on Wallet for an account with funds

Device sessions

Passed tests (45)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_add_to_contacts
Device sessions

11. test_sign_typed_message (TestRail link is not found)
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_modify_transaction_fee_values
Device sessions

18. test_send_eth_from_wallet_to_address
Device sessions

19. test_manage_assets
Device sessions

20. test_logcat_send_transaction_in_1_1_chat
Device sessions

21. test_request_and_receive_eth_in_1_1_chat
Device sessions

22. test_swipe_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_messaging_in_different_networks
Device sessions

27. test_send_tokens_in_1_1_chat
Device sessions

28. test_network_mismatch_for_send_request_commands
Device sessions

29. test_logcat_sign_message_from_daap
Device sessions

30. test_swipe_to_delete_1_1_chat
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_send_eth_in_1_1_chat
Device sessions

34. test_login_with_new_account
Device sessions

35. test_send_eth_from_wallet_to_contact
Device sessions

36. test_add_contact_from_public_chat
Device sessions

37. test_password_in_logcat_creating_account
Device sessions

38. test_backup_recovery_phrase
Device sessions

39. test_offline_status
Device sessions

40. test_open_google_com_via_open_dapp
Device sessions

41. test_unread_messages_counter_public_chat
Device sessions

42. test_sign_message_from_daap
Device sessions

43. test_user_can_remove_profile_picture
Device sessions

44. test_request_eth_in_wallet
Device sessions

45. test_refresh_button_browsing_app_webview
Device sessions

@churik churik removed their assignment May 6, 2019
@dmitryn dmitryn force-pushed the bug/7911-logout-after-reset branch from f90f762 to b477faf Compare May 6, 2019 12:32
@dmitryn dmitryn requested a review from gravityblast May 6, 2019 12:35
@dmitryn
Copy link
Contributor Author

dmitryn commented May 6, 2019

@gravityblast can you please approve? Goran was removed from status org and his approval is no longer valid.

@dmitryn
Copy link
Contributor Author

dmitryn commented May 6, 2019

@asemiankevich i've fixed the errors, but i need to get more approvals to start build

@dmitryn
Copy link
Contributor Author

dmitryn commented May 6, 2019

@flexsurfer @rasom can you guys re-approve please as old approval is no longer valid.

@dmitryn
Copy link
Contributor Author

dmitryn commented May 6, 2019

@asemiankevich build is ready http://status-im-prs.ams3.digitaloceanspaces.com/StatusIm-190506-123255-b477fa-pr.apk

@dmitryn dmitryn force-pushed the bug/7911-logout-after-reset branch from b477faf to 311f6de Compare May 8, 2019 11:33
@dependency-lockfile-snitch
Copy link

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

@dmitryn
[#7911 #7894] delete account and logout after keycard reset
99e0089 
Signed-off-by: Dmitry Novotochinov <dmitry.novot@gmail.com>
@dmitryn dmitryn force-pushed the bug/7911-logout-after-reset branch from 311f6de to 99e0089 Compare May 8, 2019 11:35
@dmitryn dmitryn merged commit 99e0089 into develop May 8, 2019
@dmitryn dmitryn deleted the bug/7911-logout-after-reset branch May 8, 2019 11:35
@dependency-lockfile-snitch
Copy link

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

@guylouis guylouis mentioned this pull request Aug 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasom rasom rasom approved these changes

@goranjovic goranjovic goranjovic approved these changes

@jeluard jeluard jeluard approved these changes

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

@gravityblast gravityblast Awaiting requested review from gravityblast

Assignees
No one assigned
Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone