[Fixed #8008] Fixed DApps permission regression #8010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (18)
|
jeluard
force-pushed
the
8008
branch
2 times, most recently
from
f65595e
to
5cb7cf7
Compare
goranjovic
approved these changes
Apr 22, 2019
| (re-frame/reg-sub | ||
| ::dapps | ||
| (fn [db] | ||
| (:contacts/dapps db))) |
There was a problem hiding this comment.
minor nitpick - is there any value in having this as a local sub as opposed to just nesting (:contacts/dapps db) in the calling code?
There was a problem hiding this comment.
No personal opinion on this. I just reverted some previously deleted code.
|
we don't have dapps in contacts anymore, we removed them when implemented dap.ps discovery dapp, so i prepared the proper fix for this issue #8017, thanks |
|
Closing in favour of #8017 |
Pull Request Checklist
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8008
Summary
Fixed regression breaking DApps permission screen.
status: ready