Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gaps on desktop #8012

Merged
merged 1 commit into from
May 1, 2019
Merged

Gaps on desktop #8012

merged 1 commit into from
May 1, 2019

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Apr 22, 2019 •
edited by StatusWrike
Loading

Implemented as a single component for all platforms.

status: ready

@rasom rasom self-assigned this Apr 22, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Apr 22, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (30)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 084314d #1 2019-04-22 12:25:12 ~15 min macos 📦 dmg
✔️ 084314d #1 2019-04-22 12:26:25 ~16 min android 📦 apk
✔️ 084314d #1 2019-04-22 12:26:55 ~16 min linux 📦 App
✔️ 084314d #1 2019-04-22 12:27:25 ~17 min android-e2e 📦 apk
✔️ 084314d #1 2019-04-22 12:28:01 ~17 min windows 📦 exe
✔️ 084314d #1 2019-04-22 12:35:32 ~25 min ios 📦 ipa
❌ 481183f #2 2019-04-22 13:22:10 ~14 min android 📄 log
✔️ 481183f #2 2019-04-22 13:23:22 ~15 min macos 📦 dmg
✔️ 481183f #2 2019-04-22 13:24:33 ~17 min android-e2e 📦 apk
❌ 481183f #2 2019-04-22 13:25:31 ~18 min linux 📄 log
❌ 481183f #2 2019-04-22 13:30:59 ~23 min windows 📄 log
✔️ 481183f #2 2019-04-22 13:33:10 ~25 min ios 📦 ipa
✔️ e9975ed #3 2019-04-24 19:49:39 ~14 min macos 📦 dmg
✔️ e9975ed #3 2019-04-24 19:50:45 ~16 min linux 📦 App
✔️ e9975ed #3 2019-04-24 19:51:26 ~16 min android-e2e 📦 apk
✔️ e9975ed #3 2019-04-24 19:58:13 ~23 min ios 📦 ipa
✔️ e9975ed #3 2019-04-24 19:58:14 ~23 min android 📦 apk
✔️ e9975ed #3 2019-04-24 19:58:26 ~23 min windows 📦 exe
✔️ e471f02 #4 2019-04-26 08:30:42 ~15 min macos 📦 dmg
✔️ e471f02 #4 2019-04-26 08:30:46 ~16 min android 📦 apk
✔️ e471f02 #4 2019-04-26 08:30:59 ~16 min windows 📦 exe
✔️ e471f02 #4 2019-04-26 08:31:06 ~16 min android-e2e 📦 apk
✔️ e471f02 #4 2019-04-26 08:31:33 ~16 min linux 📦 App
✔️ e471f02 #4 2019-04-26 08:37:06 ~22 min ios 📦 ipa
✔️ 5778150 #5 2019-04-26 13:31:42 ~19 min android 📦 apk
✔️ 5778150 #5 2019-04-26 13:32:49 ~20 min macos 📦 dmg
✔️ 5778150 #5 2019-04-26 13:39:49 ~27 min ios 📦 ipa
✔️ 5778150 #5 2019-04-26 13:40:11 ~28 min linux 📦 App
✔️ 5778150 #5 2019-04-26 13:42:49 ~30 min android-e2e 📦 apk
✔️ 5778150 #5 2019-04-26 13:43:24 ~31 min windows 📦 exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6bdf025 #6 2019-05-01 06:01:37 ~15 min macos 📦 dmg
✔️ 6bdf025 #6 2019-05-01 06:02:40 ~16 min android-e2e 📦 apk
✔️ 6bdf025 #6 2019-05-01 06:03:15 ~17 min windows 📦 exe
✔️ 6bdf025 #6 2019-05-01 06:06:44 ~20 min linux 📦 App
✔️ 6bdf025 #6 2019-05-01 06:13:52 ~27 min ios 📦 ipa
✔️ 6bdf025 #7 2019-05-01 08:04:21 ~18 min android 📦 apk
✔️ b90f1e5 #7 2019-05-01 08:31:59 ~13 min macos 📦 dmg
✔️ b90f1e5 #7 2019-05-01 08:35:18 ~16 min android-e2e 📦 apk
✔️ b90f1e5 #8 2019-05-01 08:35:49 ~17 min android 📦 apk
✔️ b90f1e5 #7 2019-05-01 08:36:13 ~17 min windows 📦 exe
✔️ b90f1e5 #7 2019-05-01 08:41:49 ~23 min linux 📦 App
✔️ b90f1e5 #7 2019-05-01 08:45:39 ~27 min ios 📦 ipa

@rasom rasom changed the title Gaps on desktop [WIP] Gaps on desktop Apr 22, 2019
@rasom rasom force-pushed the gaps-on-desktop branch 3 times, most recently from e9975ed to e471f02 Compare April 26, 2019 08:14
@rasom rasom changed the title [WIP] Gaps on desktop Gaps on desktop Apr 26, 2019
@rasom rasom requested review from cammellos, flexsurfer and yenda and removed request for cammellos April 26, 2019 08:23
@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2019
Closed
@oskarth oskarth requested a review from a team April 30, 2019 03:16
@churik churik self-assigned this Apr 30, 2019
@statustestbot
Copy link

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 3
Passed tests: 45

Failed tests (3)

Click to expand
1. test_messaging_in_different_networks

Device 2: Wait for PasswordInput
Device 2: Wait for OkButton

Device 2: 'PasswordInput' is not found on the screen

Device sessions

2. test_backup_recovery_phrase

Device 1: Tap on DoneButton
Device 1: Tap on YesButton

Device 1: 'OkGotItButton' is not found on the screen

Device sessions

3. test_backup_recovery_phrase_warning_from_wallet

Device 1: Tap on DoneButton
Device 1: Tap on YesButton

Device 1: 'OkGotItButton' is not found on the screen

Device sessions

Passed tests (45)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_add_to_contacts
Device sessions

11. test_sign_typed_message (TestRail link is not found)
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_modify_transaction_fee_values
Device sessions

18. test_send_eth_from_wallet_to_address
Device sessions

19. test_manage_assets
Device sessions

20. test_logcat_send_transaction_in_1_1_chat
Device sessions

21. test_request_and_receive_eth_in_1_1_chat
Device sessions

22. test_swipe_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_send_tokens_in_1_1_chat
Device sessions

27. test_network_mismatch_for_send_request_commands
Device sessions

28. test_logcat_sign_message_from_daap
Device sessions

29. test_swipe_to_delete_1_1_chat
Device sessions

30. test_switch_users_and_add_new_account
Device sessions

31. test_send_stt_from_wallet
Device sessions

32. test_send_eth_in_1_1_chat
Device sessions

33. test_login_with_new_account
Device sessions

34. test_send_eth_from_wallet_to_contact
Device sessions

35. test_add_contact_from_public_chat
Device sessions

36. test_send_two_transactions_one_after_another_in_dapp
Device sessions

37. test_password_in_logcat_creating_account
Device sessions

38. test_offline_status
Device sessions

39. test_open_google_com_via_open_dapp
Device sessions

40. test_unread_messages_counter_public_chat
Device sessions

41. test_sign_message_from_daap
Device sessions

42. test_user_can_remove_profile_picture
Device sessions

43. test_share_contact_code_and_wallet_address
Device sessions

44. test_request_eth_in_wallet
Device sessions

45. test_refresh_button_browsing_app_webview
Device sessions

@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@rasom
Copy link
Contributor Author

rasom commented May 1, 2019

rebased onto latest develop

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 3
Failed tests: 0
Passed tests: 3

Passed tests (3)

Click to expand
1. test_messaging_in_different_networks
Device sessions

2. test_backup_recovery_phrase
Device sessions

3. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@churik
Copy link
Member

churik commented May 1, 2019

Working for me on Linux, Mac OSx, Windows on public, group and 1-1 chats.

Thanks for amazing work @rasom!
Please, delete additional options for testing before merge.

@rasom rasom merged commit b90f1e5 into develop May 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the gaps-on-desktop branch May 1, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@cammellos cammellos cammellos approved these changes

@yenda yenda Awaiting requested review from yenda

Assignees

@churik churik

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rasom @status-im-auto @statustestbot @churik @cammellos @flexsurfer