Maintain scroll position after fetching gap #8025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasom
changed the title
Jenkins BuildsClick to see older builds (13)
|
rasom
force-pushed
the
gap-maintain-position
branch
3 times, most recently
from
54fb59a
to
3ed3c3b
Compare
rasom
changed the title
cammellos
approved these changes
Apr 25, 2019
flexsurfer
approved these changes
Apr 25, 2019
| (defview gap [{:keys [ids]}] | ||
| (defview gap | ||
| [ids idx list-ref in-progress? connected?] | ||
| [react/view {:align-self :stretch |
There was a problem hiding this comment.
ehm, let me finish with desktop first, and other related PRs. I'm sure it will be changed 2-3 times during next PRs. It's just simplier to keep everything in one place for now
|
@hesterbruikman that's the best I can propose without spending too much time on this task |
Closed
|
Tested when "Fetching messages" (IOS 11.4.1, IPhone 7, Android 8, LG V20) is close to the top and to the bottom of the screen, and somewhere in the middle. Ready to merge from my after e2e |
98% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (47)Click to expand
|
|
failed e2e is due to an infrastructure issue, not related to PR |
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
mandrigin
force-pushed
the
gap-maintain-position
branch
from
cefe634
to
3a2d702
Compare
Pull Request Checklist
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the gap was shown before the first message which has
timestamphigher than gap'sfrom; in this PR the gap is shown after all messages whichtimestampis lower than gap, also after messages which are inside the gap and before the first message whichtimestampis higher than gap'sto.before:
after:
This minimizes chances that requested messages will be rendered between messages B and C instead of rendering between gap and C. In result, we can scroll to message C before loading and bottom side of the chat will maintain the same position after fetching messages (no guaranty but higher chances).
Before fetching the gap, the list is scrolled so that the next message after the gap (message C in the example above) is placed in the center of the screen. In this case, after rendering of the newly fetched messages, the user will still be able to see older, already seen messages along with new rendered messages which will replace gap above that "message C"
In some cases the app will behave properly without these changes, it depends on a number of referenced messages which are fetched and have to be rendered in responses. Also, messages like
Bmight not be present in the chat's history.status: ready