[Fixes #8066] Added native ENS registration #8248
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (23)
|
| (defn- subdomain [username] | ||
| (str username "." domain)) | ||
|
|
||
| (def registrars |
There was a problem hiding this comment.
do we actually need this?
(ens/owner "0x112234455c3a32fd11230c42e7bccd4a84e02010" "stateofus.eth" println)
0x11d9f481effd20d76cee832559bd9aca25405841
There was a problem hiding this comment.
Good point, will drop it
There was a problem hiding this comment.
Actually it's something we need to check statically and pretty often so doesn't appear to be worth the hassle and perf cost.
There was a problem hiding this comment.
what do you mean we need to check it statically? what if we change the contract address for stateofus.eth?
There was a problem hiding this comment.
Well same as if we change any contract address?
There was a problem hiding this comment.
@decanus do you have any recommendation here? Should we rather rely on hardcoded contract addresses for the registrar or solve it with the ens resolver contract?
|
@jeluard , @yenda introduced typography some time ago, so we don't need to set font styles manually anymore, typography key should be used instead, you can see typography name in figma cc @errorists |
|
@flexsurfer @yenda I made some changes |
| @@ -0,0 +1,123 @@ | |||
| (ns status-im.ui.screens.ens.events | |||
There was a problem hiding this comment.
i believe we don't use events in ui namespace, handlers should be in root events file, fx and functions in core.cljs
There was a problem hiding this comment.
There are plenty events files.
There was a problem hiding this comment.
Which is wrong there shouldnt be any
Pull Request Checklist
|
| [toolbar/content-title (i18n/label :t/ens-your-username)]]) | ||
|
|
||
| (views/defview register [] | ||
| (views/letsubs [{:keys [registrar]} [:get-screen-params :ens-register] |
There was a problem hiding this comment.
make just one subscription for the register screen with all the data you need
Signed-off-by: yenda <eric@status.im>
Signed-off-by: Dmitry Novotochinov <dmitry.novot@gmail.com>
Signed-off-by: Churikova Tetiana <churikova.tm@gmail.com>
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
Signed-off-by: yenda <eric@status.im>
…nt APIs. Connect to stubs of status-go protocol API, behind the flag. Since status-go isn't updated yet, setting this flag will break the app. What needs to be tested is no regressions in a normal mode. Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
`wallet-autoconfig-token` is a very expensive call on mainnet because it checks the balance of every known token. it is called: - when wallet is refreshed by pulling - when user goes on any wallet screen this PR changes that by: - calling it only when the wallet is initialized and there is no visible-token configuration it only calls update-wallet when a new transaction arrives
- use `json-rpc/eth-call` and `json-rpc/eth-transaction-call` everywhere - move all conversions to abi-spec
move utils.ethereum.tokens to ethereum.tokens move utils.ethereum.abi-spec to ethereum.abi-spec move utils.ethereum.core to ethereum.core move utils.ethereum.eip165 to ethereum.eip165 move utils.ethereum.eip55 to ethereum.eip55 move utils.ethereum.eip681 to ethereum.eip681 move utils.ethereum.ens to ethereum.ens move utils.ethereum.erc721 to ethereum.erc721 move utils.ethereum.mnemonics to ethereum.mnemonics move utils.ethereum.resolver to ethereum.resolver move utils.ethereum.macros to ethereum.macros Signed-off-by: yenda <eric@status.im>
|
|
|
could you fixup all these commit it can't be reviewed in that state |
There was a problem hiding this comment.
- there is still an ens events namespace, the best solution is to move to ens.core (outside of ui) and use the fx/defn attribute map like this:
{:events [:this-in-an-event]}to declare the events. - duplicated ens subscription
- internal transactions should use eth-transaction-call
|
@yenda Not done, please don't review. |
fixes #8066
Summary
Implement ENS registration according to latest Figma designs.
Note to testers Local names persistency is not part of this PR. Thus initial welcome screen is always the same even if you already registered some names using native registration.
Address and public key will be connected to names, and stateofus names can be be registered.
status: WIP