Render chat formatting natively #8410
Conversation
|
|
Pull Request Checklist
|
|
|
Jenkins BuildsClick to see older builds (101)
|
|
@annadanchenko that is how formatting looks like now: |
|
|
1 similar comment
|
|
|
Italic is done with tildes '~' in status-react is the change to underscores intentional? |
|
@yenda see |
|
progress on Android side |
|
|
|
@annadanchenko Android should be fully functional at that moment. @yenda can you send me a link to the chat where this formatting chokes? |
|
The #test2 channel from June 5 contains loads of big formatted message, though it barely takes more than a second on my phone so I think it's more obvious on low end devices |
|
I tested on Android and this PR doesn't render #test2 the app stops responding |
|
Not that the current is much better it does render but it takes a while |
|
The PR did render after restart but not much faster than develop. Not sure how you implemented it exactly but would this mean that even native is bad with heavy styling? In that case our best shot would be to use the same approach as with long messages and show less |
|
@yenda if you don't use a new account at the moment, it will re-use the old (stored in the db) message chunks, so essentially it won't do any formatting natively. |
|
also, take into account that it renders 1.5 screen of messages now and not a single message as the old version. |
|
@mandrigin waiting for builds to be fixed (build 4 for all platforms failed) |
|
After a cold start when the messages are already in db and with an account that only has #test2 channel it takes
So there is an improvement there but still not satisfying enough to call the problem solved because the chat opening shouldn't be disruptable with a single bad message. Could you also describe how this is implemented natively? I suppose it won't be as easy to expand the markdown support as it is right now? |
|
|
|
@annadanchenko pushed the fix |
|
|
1 similar comment
|
|
|
|
1 similar comment
|
|
|
Some screenshots:
|
91% of end-end tests have passedFailed tests (4)Click to expand
Passed tests (43)Click to expand |
|
|
|
build 20 Android and build 25 iOS: two__underscores__are__deleted transforms to twounderscoresaredeleted I would expect inner underscores to remain so two__underscores__are__deleted |
mandrigin
force-pushed
the
native-chat-render
branch
from
79160a8
to
566a1df
Compare
|
|
mandrigin
force-pushed
the
native-chat-render
branch
from
566a1df
to
45e7dbf
Compare
|
|
60% of end-end tests have passedFailed tests (19)Click to expand
Passed tests (28)Click to expand
|
use patched RN to make sure that heavily-formatted messages don't slow our chats down. Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
mandrigin
force-pushed
the
native-chat-render
branch
from
45e7dbf
to
7945493
Compare
|
|
fixes #8263
What to test:
#test2channel)see the changes here: status-im/react-native@c005d31
status: ready