Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9203] slow transaction history vol1 #9694

Closed
wants to merge 1 commit into from
Closed

[#9203] slow transaction history vol1 #9694

wants to merge 1 commit into from

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Dec 18, 2019 •
edited by StatusWrike
Loading

first step to fix issue #9203

based on status-im/status-go#1744

  • eth_getBalance caching
  • check eth_getTransactionCount on zero from and to balances
  • prevent extra scanning for the same address

@rasom
[#9203] slow transaction history vol1
bec7e12 
- eth_getBalance caching
- check eth_getTransactionCount on zero `from` and `to` balances
- prevent extra scanning for the same address
@rasom rasom requested a review from a team as a code owner December 18, 2019 18:08
@auto-assign auto-assign bot removed the request for review from a team December 18, 2019 18:08
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@rasom
Copy link
Contributor Author

rasom commented Dec 18, 2019 •
edited
Loading

https://etherscan.io/address/0x2f88d65f3cB52605a54A833ae118fb1363aCccd2
Data usage includes erc tokens history which hasn't been touched yet and the rest of app's communication

  1. develop, Data usage 53.9mb, 19.514074986s and 16.658236412s, app crashed
t=2019-12-18T09:50:48+0000 lvl=info msg="eth historical downloader finished successfully" address=0x2f88d65f3cB52605a54A833ae118fb1363aCccd2 total transfers=101 time=19.514074986s
t=2019-12-18T09:51:02+0000 lvl=info msg="eth historical downloader finished successfully" address=0x2f88d65f3cB52605a54A833ae118fb1363aCccd2 total transfers=101 time=16.658236412s
  1. this pr, Data usage 24.83mb, 8.916600494s
t=2019-12-18T09:33:40+0000 lvl=info msg="eth historical downloader finished successfully" address=0x2f88d65f3cB52605a54A833ae118fb1363aCccd2 total transfers=101 time=8.916600494s

@status-im-auto
Copy link
Member

status-im-auto commented Dec 18, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bec7e12 #1 2019-12-18 18:20:30 ~12 min ios 📦ipa 📲
✔️ bec7e12 #1 2019-12-18 18:26:59 ~18 min android-e2e 📦apk 📲
✔️ bec7e12 #1 2019-12-18 18:30:58 ~22 min android 📦apk 📲

@rasom rasom self-assigned this Dec 19, 2019
@weekly-digest weekly-digest bot mentioned this pull request Dec 22, 2019
Closed
@rasom rasom closed this Jan 16, 2020
@rasom rasom deleted the fix/slow-history-first-attempt branch January 16, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@yenda yenda Awaiting requested review from yenda

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasom @status-im-auto @flexsurfer