Skip to content

migrate deny list management to PostgreSQL with gRPC access #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from
Draft

migrate deny list management to PostgreSQL with gRPC access #71

wants to merge 23 commits into from

Conversation

@nadeemb53
Copy link
Member

@nadeemb53 nadeemb53 commented Nov 29, 2025

  • Modified DenyListManager and NullifierTracker to utilize gRPC for deny list operations and nullifier tracking.
  • Updated tests to reflect changes in deny list handling and nullifier tracking.
  • Adjusted Docker configurations to support new database schema for deny list and nullifiers.
  • Improved performance tests to validate high-throughput nullifier tracking and database persistence.

sydhds and others added 23 commits November 18, 2025 17:09
@sydhds
Add initial code for UserDb2
75ff5c2
@sydhds
Add prover_pmtree + prover_merkle_tree crates
602dfab
@sydhds
Add first unit tests for UserDb2
f9a1b35
@sydhds
Add UserDb2::remove_user + more unit tests
adf332f
@sydhds
Auto management of databases for unit tests
4e4d4eb
@sydhds
Add user_db_2_tests file
049fd76
@sydhds
Fix for unit test: test_new_multi_tree
1fc1820
@sydhds
Fix default tx_counter updates
31fcb89
@sydhds
Initial use of UserDb2 in prover
7a5da2d
@sydhds
UserDb2 TU now requires postgres db
62e3abf
@sydhds
UserDb2::on_new_user fixes
0a3151d
@sydhds
Fix unit tests in proof_service_tests.rs
39b5072
@sydhds
Restore unit tests in karma_sc_listener.rs
a3566ef
@sydhds
Fix grpc e2e tests
ba66b47
@sydhds
Cargo clippy fixes
533283b
@sydhds
Cargo fmt
1cbd5c6
@sydhds
Fix unused deps
f16f2e9
@sydhds
Restore batch insert_many
7f821c3
@sydhds
Update sea-orm to 2.0.0-rc.19
32a7f42
@sydhds
Prover bench fixes
dc5168d
@sydhds
Cargo fmt
4406f58
@nadeemb53
Merge branch 'feat/prover_db' into feat/denylist-prover-db
3bf4bf3
@nadeemb53
refactor: migrate deny list management to PostgreSQL with gRPC access
ab7a3dc
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 29, 2025
View reviewed changes
...er/src/main/java/net/consensys/linea/sequencer/txpoolvalidation/shared/NullifierTracker.java
this(serviceName, 1_000_000L, nullifierExpiryHours); // Default to 1M capacity
LOG.info(
"{}: Using in-memory nullifier tracking (file path ignored for performance)", serviceName);
public NullifierTracker(String serviceName, String storagePath, long nullifierExpiryHours) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'storagePath' is never used.

Copilot Autofix

AI 1 day ago

To fix the problem, remove the unused parameter storagePath from the legacy constructor of NullifierTracker. This entails:

  • Edit the constructor signature at line 151 to remove the String storagePath parameter.
  • Remove mentions of storagePath in the Javadoc comment, updating @param accordingly.
  • Ensure the remaining constructor arguments still work as intended.
  • The log message inside this constructor already notes that the storage path is ignored, so it can remain, but the parameter string should be removed.
Suggested changeset 1
besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/sequencer/txpoolvalidation/shared/NullifierTracker.java

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/sequencer/txpoolvalidation/shared/NullifierTracker.java b/besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/sequencer/txpoolvalidation/shared/NullifierTracker.java
--- a/besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/sequencer/txpoolvalidation/shared/NullifierTracker.java
+++ b/besu-plugins/linea-sequencer/sequencer/src/main/java/net/consensys/linea/sequencer/txpoolvalidation/shared/NullifierTracker.java
@@ -142,13 +142,12 @@
   }
 
   /**
-   * Legacy constructor for backward compatibility with file path parameter.
+   * Legacy constructor for backward compatibility.
    *
    * @param serviceName Service name for logging
-   * @param storagePath Ignored - DB storage is handled via gRPC
    * @param nullifierExpiryHours Expiry time in hours
    */
-  public NullifierTracker(String serviceName, String storagePath, long nullifierExpiryHours) {
+  public NullifierTracker(String serviceName, long nullifierExpiryHours) {
     this(serviceName, 1_000_000L, nullifierExpiryHours);
     LOG.info("{}: Storage path ignored - using PostgreSQL via gRPC", serviceName);
   }
EOF
@@ -142,13 +142,12 @@
}

/**
* Legacy constructor for backward compatibility with file path parameter.
* Legacy constructor for backward compatibility.
*
* @param serviceName Service name for logging
* @param storagePath Ignored - DB storage is handled via gRPC
* @param nullifierExpiryHours Expiry time in hours
*/
public NullifierTracker(String serviceName, String storagePath, long nullifierExpiryHours) {
public NullifierTracker(String serviceName, long nullifierExpiryHours) {
this(serviceName, 1_000_000L, nullifierExpiryHours);
LOG.info("{}: Storage path ignored - using PostgreSQL via gRPC", serviceName);
}
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nadeemb53 @sydhds