[WIP] Change App ID for PR builds of iOS app #7479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (140)
|
|
The way I made the It's related to the flags given to |
jakubgs
changed the title
|
@jakubgs do you need any help with that? |
|
I kinda put it on hold for a while. Now that the Android one has been fixed I can take a look at it again. I tried make a separate ID and name using the XCode UI and then look at the changes in the |
jakubgs
force-pushed
the
change-ios-app-id
branch
from
3276600
to
be82264
Compare
|
@jakubgs yeah, I think we should use it. It is a better approach than doing everything in pbproj file |
|
My main issue is that This must be caused by some of the changes in |
jakubgs
force-pushed
the
change-ios-app-id
branch
3 times, most recently
from
5074f55
to
2f21f64
Compare
|
Aaaaand we're back to the same old bullshit:
|
|
As far as I can tell this is related to |
|
So I lookad at what's in And looked inside of |
|
@jakubgs is this still relevant? |
|
@flexsurfer I wish. I've been so busy with a lot of other things which are more related to infra that I haven't had the time to work on this at all. Now I'm busy helping with new development infra for future version of https://dap.ps/. I do want to finish this, but don't have the time. I was also pretty darn stuck the last time I looked at this as far as I recall. |
jakubgs
force-pushed
the
change-ios-app-id
branch
3 times, most recently
from
b9a544d
to
dcf399d
Compare
jakubgs
force-pushed
the
change-ios-app-id
branch
from
dcf399d
to
23d36ed
Compare
jakubgs
force-pushed
the
change-ios-app-id
branch
2 times, most recently
from
3f038d6
to
0d125e4
Compare
jakubgs
force-pushed
the
change-ios-app-id
branch
from
2faa74d
to
f020ce7
Compare
Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
change-ios-app-id
branch
from
f020ce7
to
118938a
Compare
Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 29, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 29, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 29, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 29, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 29, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 29, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 30, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 30, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 30, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 30, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
that referenced
this pull request
Jun 30, 2019
A successor to #7479 Signed-off-by: Jakub Sokołowski <jakub@status.im>
|
I suggest closing this if we can't get it merged this week, and we can reopen it when it is more of a priority. |
|
Fine by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR to #7287 for changing App ID of iOS PR builds to
im.status.ethereum.pr.I've added the necessary profile in
ios-certificatesrepo here: https://github.com/status-im/ios-certificates/commit/6c3104907319a45efc72f05dc98ad1714d4560b3State: WIP