Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Decouple whisper key from wallet key #292

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Conversation

gravityblast
Copy link
Member

@gravityblast gravityblast commented Aug 1, 2018

the description of the idea is in the ideas/292-decouple-whisper-key-from-wallet-key.md file

@gravityblast gravityblast changed the title [WIP] add base template for "Decouple whisper key from wallet key" idea Decouple whisper key from wallet key Aug 2, 2018
Copy link

@pedropombeiro pedropombeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left some questions an a couple minor nits.


### Problems to solve for old clients

1 - user A is using an old client

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: right now this formatting is not working for me (i.e. all the items appear in the same line instead of a list). Also, it would be nice to change it to always use 1., and let the rendering engine assign the correct numbers (this is an issue pointed in md linters).

2 - user B is using a new client
3 - user A is chatting with user B and sends a transaction from the chat
4 - the transaction from the old client will be sent to the address derived from the chat contact code of user B
5 - user B won't see the transaction in the wallet because the wallet address is derived from a different key.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand how there will be an issue here. Is it in the scenario where user A only added user B as a contact after user B started using the new client? In any case, since the wallet address is not changing, I'd suppose that user B would see his wallet balance changing, since that's where user A is sending the transaction to. I.e. the address derived from the chat contact code of user B==new wallet address, right?


The chat contact will change so after the upgrade, users will need to exchange their contact again to be able to chat.

### Problems to solve for old clients

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this is not rendering as a header in GH.


The key pair used for the wallet will remain the same, so the wallet address won't change.

The chat contact will change so after the upgrade, users will need to exchange their contact again to be able to chat.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be any UX solution to let the user know that there 1:1 chat will not work anymore? Maybe we can mark all existing 1:1 chats as obsolete and show some message in those ones.

@oskarth
Copy link
Contributor

oskarth commented Aug 17, 2018

This is definitely important for privacy.

From a priority point of view, how does this fit into current teams/OKRs/prios? Thinking about things like PFS, HW wallet etc. I.e. when does it make sense to push it?

@pedropombeiro
Copy link

This seems tied to the Wall of shame OKR, specifically the "18. Same key used across all DApps" entry. Maybe that entry needs to be expanded to include whisper/wallet identities.

@oskarth oskarth merged commit f502778 into master Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants