#259: Chaperone Tree Relations #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tylernathanreed, |
staudenmeir
reviewed
Sep 5, 2024
|
Can you please add a test to this file? |
|
I have added a test. |
staudenmeir
reviewed
Sep 8, 2024
SanderMuller
suggested changes
Sep 9, 2024
Co-authored-by: Sander Muller <github@scode.nl>
Co-authored-by: Sander Muller <github@scode.nl>
Co-authored-by: Sander Muller <github@scode.nl>
Co-authored-by: Sander Muller <github@scode.nl>
Co-authored-by: Sander Muller <github@scode.nl>
Co-authored-by: Sander Muller <github@scode.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently working on something where I pulled in a tree, and I needed to access information regarding ancestors of the tree. Tapping into these relations caused database queries, despite the models being within the collection already. This resulted in loading 5x the number of models as I had records in the table.
The solution for something like this would be to manually load in the parent/ancestor relations, so that if these relations are called, they load models already in memory, rather than reaching out to the database again.
I've created a new
loadTreePathRelations()method, which loads theparent,ancestorsAndSelf, andancestorsrelations, which sources as much as possible from the existing collection.