Fixing up threading for downloads

download.py

@@ -5,7 +5,7 @@
 
 class Downloader(object):
 
-    def __init__(self, api, thread_count, ips, delay=1):
+    def __init__(self, api, thread_count, ips, delay=1, processed_callback=lambda _: None):
         self.lock = Lock()
         self.api = api
         self.thread_count = thread_count
@@ -14,13 +14,15 @@ def __init__(self, api, thread_count, ips, delay=1):
         self.queue = Queue(len(ips))
         self.threads = []
         self.results = []
+        self._start_threads(processed_callback)
 
-    def download(self, processed_callback=lambda _: None):
+    def _start_threads(self,processed_callback):
         for count in range(0, self.thread_count):
             thread = Thread(target=self._download_host, name=f'downloader-{count}', args=(processed_callback,))
             thread.setDaemon(True)
             thread.start()
 
+    def download(self):
         for ip in self.ips:
             self.queue.put(ip)
             sleep(self.delay)  # shodan API is rate limited so requires a delay between reqs

showdown.py

@@ -113,8 +113,8 @@ def main(args):
     log.write(colored('[-] No details', 'red'))
     log.write(f"[+] Processing {len(ips)} hosts: ", end='', flush=True)
 
-    downloader = Downloader(api, args.threads, ips)
-    hosts = downloader.download(processed_callback=ip_processed)
+    downloader = Downloader(api, args.threads, ips, processed_callback=ip_processed)
+    hosts = downloader.download()
     print()
 
     # no details for any of the hosts, nothing more to do!