Command Palette: Add language names for the entirety of ISO 639 language codes #28
+8,133
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BanchouBoo
changed the title
|
8100 languages is too large and too slow. |
|
I was concerned about speed when I was putting it together but didn't encounter any issues with it in practice. Did you test it and have performance issues? |
|
There could be users perceive it as bloat. I can add some more on request, in the end I prefer to have under 50 languages, currently it's 20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This complicates the install process a little bit. You install
language_table.luato thescript-modulesfolder, and if it is present it will be used for lookups for language names, if it doesn't exist it will just display the language code itself.