Skip to content

Commit

Permalink
Accessibility: improve the color contrast in the Edit Comment "Status…
Browse files Browse the repository at this point in the history
…" box.

The current orange and red used for the radio button labels in the Edit Comment
"Status" box don't have a sufficient color contrast ratio with the background.
Removing the colors improves accessibility and consistency.

See #35659, #35622.
Fixes #36967.

git-svn-id: https://develop.svn.wordpress.org@37611 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
afercia committed Jun 1, 2016
1 parent 5cbc8de commit 087861a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 16 deletions.
13 changes: 0 additions & 13 deletions trunk/src/wp-admin/css/edit.css
Original file line number Diff line number Diff line change
Expand Up @@ -634,19 +634,6 @@ span.wp-media-buttons-icon:before {
max-width: 100%;
}

#poststuff .inside label.spam,
#poststuff .inside label.deleted {
color: red;
}

#poststuff .inside label.waiting {
color: orange;
}

#poststuff .inside label.approved {
color: green;
}

.ie8 #poststuff .inside #parent_id,
.ie8 #poststuff .inside #page_template {
width: 250px;
Expand Down
6 changes: 3 additions & 3 deletions trunk/src/wp-admin/edit-form-comment.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@

<fieldset class="misc-pub-section misc-pub-comment-status" id="comment-status-radio">
<legend class="screen-reader-text"><?php _e( 'Comment status' ); ?></legend>
<label class="approved"><input type="radio"<?php checked( $comment->comment_approved, '1' ); ?> name="comment_status" value="1" /><?php _ex( 'Approved', 'comment status' ); ?></label><br />
<label class="waiting"><input type="radio"<?php checked( $comment->comment_approved, '0' ); ?> name="comment_status" value="0" /><?php _ex( 'Pending', 'comment status' ); ?></label><br />
<label class="spam"><input type="radio"<?php checked( $comment->comment_approved, 'spam' ); ?> name="comment_status" value="spam" /><?php _ex( 'Spam', 'comment status' ); ?></label>
<label><input type="radio"<?php checked( $comment->comment_approved, '1' ); ?> name="comment_status" value="1" /><?php _ex( 'Approved', 'comment status' ); ?></label><br />
<label><input type="radio"<?php checked( $comment->comment_approved, '0' ); ?> name="comment_status" value="0" /><?php _ex( 'Pending', 'comment status' ); ?></label><br />
<label><input type="radio"<?php checked( $comment->comment_approved, 'spam' ); ?> name="comment_status" value="spam" /><?php _ex( 'Spam', 'comment status' ); ?></label>
</fieldset>

<div class="misc-pub-section curtime misc-pub-curtime">
Expand Down

0 comments on commit 087861a

Please sign in to comment.