chore: update tsconfigs to use composite (remix-run#4269)

Speeds up build a bit by allowing tsc to quickly find references: https://www.typescriptlang.org/docs/handbook/project-references.html#composite Allows projects to build in more isolation and avoids wired x-project types to leak. For example I have a PR open right now that does not recognize `headers.entries()` as a method in the server-runtime, but with these changes it works fine.
staylor · Sep 26, 2022 · 68790fb · 68790fb
1 parent 33e110d
commit 68790fb
Show file tree

Hide file tree

Showing 17 changed files with 18 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -6,6 +6,7 @@
 /packages/*/LICENSE.md
 node_modules/
 yarn-error.log
+tsconfig.tsbuildinfo
 
 /jacob
 /fixtures/cloudflare

diff --git a/integration/tsconfig.json b/integration/tsconfig.json
@@ -1,4 +1,5 @@
 {
+  "include": ["**/*.ts"],
   "exclude": ["helpers/*-template"],
   "compilerOptions": {
     "lib": ["ES2019"],

diff --git a/packages/create-remix/tsconfig.json b/packages/create-remix/tsconfig.json
@@ -6,6 +6,7 @@
     "target": "ES2019",
     "module": "CommonJS",
     "skipLibCheck": true,
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix-architect/tsconfig.json b/packages/remix-architect/tsconfig.json
@@ -5,6 +5,7 @@
     "lib": ["ES2019", "DOM.Iterable"],
     "target": "ES2019",
     "skipLibCheck": true,
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix-cloudflare-pages/tsconfig.json b/packages/remix-cloudflare-pages/tsconfig.json
@@ -5,6 +5,7 @@
     "lib": ["ES2019"],
     "target": "ES2019",
     "types": ["@cloudflare/workers-types"],
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix-cloudflare-workers/tsconfig.json b/packages/remix-cloudflare-workers/tsconfig.json
@@ -5,6 +5,7 @@
     "lib": ["ES2019"],
     "target": "ES2019",
     "types": ["@cloudflare/workers-types"],
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix-cloudflare/tsconfig.json b/packages/remix-cloudflare/tsconfig.json
@@ -5,6 +5,7 @@
     "lib": ["ES2019"],
     "target": "ES2019",
     "types": ["@cloudflare/workers-types"],
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix-dev/tsconfig.json b/packages/remix-dev/tsconfig.json
@@ -1,9 +1,11 @@
 {
+  "include": ["**/*.ts", "package.json"],
   "exclude": ["dist", "__tests__", "node_modules", "./compiler/shims"],
   "compilerOptions": {
     "lib": ["ES2019", "DOM.Iterable"],
     "target": "ES2019",
     "module": "CommonJS",
+    "composite": true,
 
     "moduleResolution": "node",
     "resolveJsonModule": true,

diff --git a/packages/remix-express/tsconfig.json b/packages/remix-express/tsconfig.json
@@ -5,6 +5,7 @@
     "lib": ["ES2019", "DOM.Iterable"],
     "target": "ES2019",
     "skipLibCheck": true,
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix-netlify/tsconfig.json b/packages/remix-netlify/tsconfig.json
@@ -4,6 +4,7 @@
     "lib": ["ES2019", "DOM.Iterable"],
     "target": "ES2019",
     "skipLibCheck": true,
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix-node/tsconfig.json b/packages/remix-node/tsconfig.json
@@ -4,6 +4,7 @@
   "compilerOptions": {
     "lib": ["ES2019", "DOM.Iterable"],
     "target": "ES2019",
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix-react/tsconfig.json b/packages/remix-react/tsconfig.json
@@ -6,6 +6,7 @@
     "target": "ES2020",
     "module": "ES2020",
     "skipLibCheck": true,
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,
@@ -14,7 +15,6 @@
     "declaration": true,
     "emitDeclarationOnly": true,
     "rootDir": ".",
-    "outDir": "../../build/node_modules/@remix-run/react/dist",
-    "composite": true
+    "outDir": "../../build/node_modules/@remix-run/react/dist"
   }
 }
diff --git a/packages/remix-serve/tsconfig.json b/packages/remix-serve/tsconfig.json
@@ -5,6 +5,7 @@
     "lib": ["ES2019", "DOM.Iterable"],
     "target": "ES2019",
     "skipLibCheck": true,
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix-server-runtime/tsconfig.json b/packages/remix-server-runtime/tsconfig.json
@@ -4,6 +4,7 @@
   "compilerOptions": {
     "lib": ["ES2019", "DOM", "DOM.Iterable"],
     "target": "ES2019",
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,
@@ -12,7 +13,6 @@
     "emitDeclarationOnly": true,
     "rootDir": ".",
     "outDir": "../../build/node_modules/@remix-run/server-runtime/dist",
-    "composite": true,
 
     // Avoid naming conflicts between lib.dom.d.ts and globals.ts
     "skipLibCheck": true

diff --git a/packages/remix-vercel/tsconfig.json b/packages/remix-vercel/tsconfig.json
@@ -5,6 +5,7 @@
     "lib": ["ES2019", "DOM.Iterable"],
     "target": "ES2019",
     "skipLibCheck": true,
+    "composite": true,
 
     "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,

diff --git a/packages/remix/tsconfig.json b/packages/remix/tsconfig.json
@@ -6,6 +6,7 @@
     "target": "ES2020",
     "module": "ES2020",
     "skipLibCheck": true,
+    "composite": true,
 
     "jsx": "react",
     "moduleResolution": "node",

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,6 +1,5 @@
 {
   "files": [],
-  "exclude": ["node_modules", "build"],
   "references": [
     { "path": "integration" },
     { "path": "packages/create-remix" },