Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the Python attribute protocol #15

Merged
merged 2 commits into from
May 14, 2015
Merged

Implemented the Python attribute protocol #15

merged 2 commits into from
May 14, 2015

Conversation

apalala
Copy link
Contributor

@apalala apalala commented May 8, 2015

The behavior regarding attributes was unexpected.

Now these work:

hasattribute(element, 'aname')
getattribute(element, 'aname', [])

hasattribute(element, 'aname')

getattribute(element, 'aname', [])
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 36.73% when pulling c61743a on apalala:master into 06d60a8 on stchris:master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.81% when pulling c61743a on apalala:master into 06d60a8 on stchris:master.

@stchris
Copy link
Owner

stchris commented May 9, 2015

Looks good. Could you add some basic tests?

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.58% when pulling 338c880 on apalala:master into 06d60a8 on stchris:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 36.73% when pulling 338c880 on apalala:master into 06d60a8 on stchris:master.

@apalala
Copy link
Contributor Author

apalala commented May 13, 2015

I added the test cases.

stchris pushed a commit that referenced this pull request May 14, 2015
Implemented the Python attribute protocol
@stchris stchris merged commit d0687a1 into stchris:master May 14, 2015
@stchris
Copy link
Owner

stchris commented May 14, 2015

Awesome, thanks! Feel free to submit your name to the AUTHORS file if you'd like to be mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants