-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add meson build/tests with asan/ubsan/msan #101
Conversation
ed0b38a
to
6c8739f
Compare
ubsan fails on my machine: gcc:
clang:
|
clang detects more error:
|
2aa946d
to
2e6b01f
Compare
ce832c1
to
f5bd0d1
Compare
All test passed 🥳 |
cc @tylov - anytime to check on this? |
Thanks, will do tonight. |
you shall also sort the additional tests and integrations by your interest, so I could implement this in a specific order. my personal priority:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, but why include <stdio.h>?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention was to use size_t and not uint64_t for hashing because it should work optimally on 32-bit as well. The hash function is designed for that. You can include <stddef.h> to get size_t on all platforms.
Seems clangd auto-included that and I didn't notice. Will fix it. |
I see many inconsistencies in the repo: there are also many APIs using uint64_t as the hash return type. if you'd like to refactor it, let's move it to another PR :) |
Thanks for this contribution! I will test this out some more, but it's a very good start. |
Notes:
Additional smoke tests that are not in this PR - let me know if you're interested in any of them: