singleheader.py fixes for Windows and newer Python #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows assumes cp1252 resulting in:
...
File "c:\src\dyibicc\scratch\STC\src\singleheader.py", line 47, in process_file
process_file(
File "c:\src\dyibicc\scratch\STC\src\singleheader.py", line 28, in process_file
for line in f:
File "C:\Program Files\Python312\Lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 426: character maps to <undefined>
Additionally, \* seems to have changed in recent Py3 versions (?), so
they need an extra backslash:
...\STC\src\singleheader.py:30: SyntaxWarning: invalid escape sequence '\*'
if re.search('/\*.*?\*/', line):
|
Thanks. I have enabled "Beta:Use Unicode UTF-8 for worldwide language support" in the system locale settings in windows, so I don't notice this kind of issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows assumes cp1252 resulting in:
Additionally,
\*seems to have changed in recent Py3 versions (?), so they need an extra backslash: