Fix issue with cbits_resize overwriting data when shrinking #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for my slow response. Thanks! I haven't actually tested it, but it seems 100% correct that this block should only run when resizing down. Accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
This pull request addresses an issue where
cbits_resize()could overwrite the existing data stored in a buffer entry if the cbits object is resized down from a buffer entry-aligned size (such as 64, 128, etc), to one that is not aligned (such as 50 or 100).I'm not sure if this is the best approach, but it does appear to fix the issue for me. Let me know if there's anything else I need to do, or if this is not an acceptable fix.