fix: apply code review suggestions

stdlib-js · Nov 17, 2024 · 537f237 · 537f237
1 parent b75e1a7
commit 537f237
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/README.md b/lib/node_modules/@stdlib/blas/ext/base/drev/README.md
@@ -181,7 +181,7 @@ stdlib_strided_drev( 4, x, 1 );
 The function accepts the following arguments:
 
 -   **N**: `[in] CBLAS_INT` number of indexed elements.
--   **X**: `[in] double*` input array.
+-   **X**: `[inout] double*` input array.
 -   **strideX**: `[in] CBLAS_INT` stride length for `X`.
 
 ```c
@@ -201,7 +201,7 @@ stdlib_strided_drev_ndarray( 4, x, 1, 0 );
 The function accepts the following arguments:
 
 -   **N**: `[in] CBLAS_INT` number of indexed elements.
--   **X**: `[in] double*` input array.
+-   **X**: `[inout] double*` input array.
 -   **strideX**: `[in] CBLAS_INT` stride length for `X`.
 -   **offsetX**: `[in] CBLAS_INT` starting index for `X`.
 

diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/lib/drev.js b/lib/node_modules/@stdlib/blas/ext/base/drev/lib/drev.js
@@ -43,7 +43,7 @@ var ndarray = require( './ndarray.js' );
 * // x => <Float64Array>[ -3.0, -1.0, 0.0, 4.0, -5.0, 3.0, 1.0, -2.0 ]
 */
 function drev( N, x, strideX ) {
-	return ndarray( N, x, strideX, stride2offset( N, strideX) );
+	return ndarray( N, x, strideX, stride2offset( N, strideX ) );
 }
 
 

diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/src/addon.c b/lib/node_modules/@stdlib/blas/ext/base/drev/src/addon.c
@@ -36,7 +36,7 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
 	STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 );
 	STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 );
 	STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 );
-	API_SUFFIX(stdlib_strided_drev)( N, (double *)X, strideX );
+	API_SUFFIX(stdlib_strided_drev)( N, X, strideX );
 	return NULL;
 }
 
@@ -53,7 +53,7 @@ static napi_value addon_method( napi_env env, napi_callback_info info ) {
 	STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 );
 	STDLIB_NAPI_ARGV_INT64( env, offsetX, argv, 3 );
 	STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 );
-	API_SUFFIX(stdlib_strided_drev_ndarray)( N, (double *)X, strideX, offsetX );
+	API_SUFFIX(stdlib_strided_drev_ndarray)( N, X, strideX, offsetX );
 	return NULL;
 }
 

diff --git a/lib/node_modules/@stdlib/blas/ext/base/drev/src/main.c b/lib/node_modules/@stdlib/blas/ext/base/drev/src/main.c
@@ -41,12 +41,12 @@ void API_SUFFIX(stdlib_strided_drev)( const CBLAS_INT N, double *X, const CBLAS_
 * @param offsetX  starting index
 */
 void API_SUFFIX(stdlib_strided_drev_ndarray)( const CBLAS_INT N, double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX ) {
-	double tmp;
 	CBLAS_INT ix;
 	CBLAS_INT iy;
 	CBLAS_INT m;
 	CBLAS_INT n;
 	CBLAS_INT i;
+	double tmp;
 
 	if ( N <= 0 ) {
 		return;