Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with skin tone emojis when using prevGraphemeClusterBreak package #1092

Open
steff456 opened this issue Aug 26, 2023 · 2 comments · May be fixed by #1431 or #2139
Open

Bug with skin tone emojis when using prevGraphemeClusterBreak package #1092

steff456 opened this issue Aug 26, 2023 · 2 comments · May be fixed by #1431 or #2139
Assignees
@Shashankss1205
Labels
Bug Something isn't working. difficulty: 3 Likely to be challenging but manageable. Good First Issue A good first issue for new contributors! Help Wanted Extra attention is needed. JavaScript Issue involves or relates to JavaScript. priority: High High priority concern or feature request.

Comments

@steff456
Copy link
Contributor

There's an issue with prevGraphemeClusterBreak package, if I compare the results with nextGraphemeClusterBreak for a single skin tone emoji it doesn't return the same values,

prevGraphemeClusterBreak( '👉🏿' ) // returns 1
nextGraphemeClusterBreak( '👉🏿' ) // returns -1

Originally posted by @steff456 in #1079 (comment)
@steff456 steff456 mentioned this issue Aug 26, 2023
Merged
6 tasks
@kgryte kgryte added the Bug Something isn't working. label Aug 26, 2023
@kgryte kgryte mentioned this issue Oct 31, 2023
Merged
5 tasks
@kgryte kgryte added Help Wanted Extra attention is needed. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. difficulty: 3 Likely to be challenging but manageable. priority: High High priority concern or feature request. labels Feb 28, 2024
@Shashankss1205
Copy link
Contributor

Can you please assign this issue to me?

@kgryte
Copy link
Member

kgryte commented Feb 29, 2024

Thank you for volunteering to work on this, @Shashankss1205. Please feel free to submit a PR addressing this bug.

@Shashankss1205 Shashankss1205 linked a pull request Mar 1, 2024 that will close this issue
Open
1 task
@kgryte kgryte mentioned this issue Mar 9, 2024
Merged
1 task
@olenkabilonizhka olenkabilonizhka linked a pull request Apr 7, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shashankss1205 Shashankss1205

Labels
Bug Something isn't working. difficulty: 3 Likely to be challenging but manageable. Good First Issue A good first issue for new contributors! Help Wanted Extra attention is needed. JavaScript Issue involves or relates to JavaScript. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
3 participants
@kgryte @steff456 @Shashankss1205