-
-
Notifications
You must be signed in to change notification settings - Fork 848
Description
This commit has 5 comment(s) from core contributors that require attention.
Commit: aec0e8848ed94f8df559aec221a457ff3e27f8f2
Comments:
-
Line 156: @stdlib-bot L155-158 should be moved to L258.
stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/mgf/README.md
Lines 153 to 159 in aec0e88
<!-- /.examples --> <!-- Section to include cited references. If references are included, add a horizontal rule *before* the section. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> <section class="references"> <!-- C interface documentation. --> -
Line 258: @stdlib-bot A closing
</section>
tag should be inserted here once the change referenced above is made.stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/mgf/README.md
Lines 255 to 261 in aec0e88
<!-- /.c --> <!-- /.references --> <!-- Section for related `stdlib` packages. Do not manually edit this section, as it is automatically populated. --> -
Line 63: @stdlib-bot Should be
] )
.stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/mgf/benchmark/benchmark.native.js
Lines 60 to 66 in aec0e88
b.tic(); for ( i = 0; i < b.iterations; i++ ) { y = mgf( t[ i%len ], mu[ i%len ], sigma[ i%len ]); if ( isnan( y ) ) { b.fail( 'should not return NaN' ); } -
Line 30: @stdlib-bot This macro should be removed.
stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/mgf/benchmark/c/benchmark.c
Lines 27 to 33 in aec0e88
#define NAME "normal-mgf" #define ITERATIONS 1000000 #define REPEATS 3 #define LEN 100 /** * Prints the TAP version. -
Line 97: @stdlib-bot Instead of
LEN
here and below, it should be a hardcoded100
. This is to ensure consistency with other similar benchmarks.stdlib/lib/node_modules/@stdlib/stats/base/dists/normal/mgf/benchmark/c/benchmark.c
Lines 94 to 100 in aec0e88
* @return elapsed time in seconds */ static double benchmark( void ) { double sigma[ LEN ]; double mu[ LEN ]; double t[ LEN ]; double elapsed;
Interested in helping improve the project? If you are, the comment linked to above has 5 comment(s) from core contributors that could use your attention.
What do you need to do?
- Open the above linked comments mentioning @stdlib-bot.
- Review the suggested changes or follow-up tasks (e.g., formatting improvements, small refactorings, or clean-up).
- If you are a first-time contributor, follow the contributing and development guides to setup your local environment for contributing to stdlib. If you are already a seasoned stdlib contributor, create a new branch on your local fork for making the changes.
- Make all the desired changes and commit those changes to a local branch.
- Push the changes to GitHub and open a new pull request against the
develop
branch of the main stdlib development repository.
Once you've opened a pull request, a stdlib maintainer will review your work and suggest any follow-up changes.
And that's it!
Thank you for your help in reducing the project backlog and in improving the quality of stdlib. 🙌
Notes
- For older commits, there is a chance that comments will have been already been addressed due to other refactorings. If you find that to be true, don't worry! Just move on to addressing the next comment, and, when opening your pull request and describing your proposed changes, be sure to link to the comment and mention that it has been addressed. This will help reviewers when reviewing your code!
This issue was created automatically to address commit comments tagging @stdlib-bot.