Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add @stdlib/string/base/replace-after-last #814

Closed
3 tasks done
kgryte opened this issue Feb 1, 2023 · 3 comments · Fixed by #1365
Closed
3 tasks done

[RFC]: Add @stdlib/string/base/replace-after-last #814

kgryte opened this issue Feb 1, 2023 · 3 comments · Fixed by #1365
Assignees
@AuenKr
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 1, 2023

Description

This RFC proposes adding a utility to replace the substring after the last occurrence of a specified search string.

Similar to other base string APIs, the package should assume valid inputs.

Logic should be similar to @stdlib/string/substring-after-last.

Package: @stdlib/string/base/replace-after-last
Alias: replaceAfterLast

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 1, 2023
@AuenKr
Copy link
Contributor

AuenKr commented Feb 23, 2024 •
edited
Loading

Hey @kgryte, Can i work on this issue?

@varunsh17
Copy link

I have read the requirements needed for this issue,
Can I be assigned so that I can start working ?
Thanks

@AuenKr AuenKr mentioned this issue Feb 24, 2024
Merged
1 task
@kgryte
Copy link
Member Author

kgryte commented Feb 24, 2024

Looks like @AuenKr has already submitted a PR for this, so will assign accordingly.

@kgryte kgryte added priority: Low Low priority concern or feature request. Utilities Issue or pull request concerning general utilities. Accepted RFC feature request which has been accepted. JavaScript Issue involves or relates to JavaScript. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Feb 24, 2024
Planeshifter added a commit that referenced this issue Feb 27, 2024
@AuenKr @kgryte @Planeshifter
feat: add string/base/replace-after-last
58bdac8 
PR-URL: #1365
Closes: #814

Signed-off-by: Golden <103646877+AuenKr@users.noreply.github.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> 
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AuenKr AuenKr

Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add string/base/replace-after-last
3 participants
@kgryte @varunsh17 @AuenKr