Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native addon to floorn and cfloorn #1003

Merged
merged 15 commits into from
Sep 23, 2023
Merged

feat: add native addon to floorn and cfloorn #1003

merged 15 commits into from
Sep 23, 2023

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Apr 20, 2023

Part of https://github.com/stdlib-js/todo/issues/1454

Description

What is the purpose of this pull request?

This pull request:

For floorn API:

  • Adds C implementation
  • Adds native addon with benchmark, tests, examples and readme update

For cfloorn API:

  • Removes out keyword
  • Adds support for Complex128 dtype
  • Adds C implementation
  • Adds native addon with benchmark, tests, examples and readme update

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

BREAKING CHANGE: out keyword is no longer supported in cfloorn and now
the function expects a double-precision complex-float number
BREAKING CHANGE: out keyword is no longer supported and now the API
supports double-precision complex floating point numbers
@steff456 steff456 added Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Apr 20, 2023
@steff456 steff456 requested review from Planeshifter and kgryte April 20, 2023 22:34
@steff456 steff456 self-assigned this Apr 20, 2023
@steff456 steff456 marked this pull request as ready for review April 20, 2023 22:34
@steff456 steff456 changed the title feat: add native addon to cfloor and cfloorn feat: add native addon to floorn and cfloorn Apr 20, 2023
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cfloorn $\color{red}253/257$
$\color{green}+98.44\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}253/257$
$\color{green}+98.44\%$
math/base/special/floorn $\color{red}269/272$
$\color{green}+98.90\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}269/272$
$\color{green}+98.90\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cfloorn $\color{red}253/257$
$\color{green}+98.44\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}253/257$
$\color{green}+98.44\%$
math/base/special/floorn $\color{red}269/272$
$\color{green}+98.90\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}269/272$
$\color{green}+98.90\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cfloorn $\color{red}253/257$
$\color{green}+98.44\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}253/257$
$\color{green}+98.44\%$
math/base/special/floorn $\color{red}269/272$
$\color{green}+98.90\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}269/272$
$\color{green}+98.90\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cfloorn $\color{red}253/257$
$\color{green}+98.44\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}253/257$
$\color{green}+98.44\%$
math/base/special/floorn $\color{red}269/272$
$\color{green}+98.90\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}269/272$
$\color{green}+98.90\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steff456 Overall this is looking good. Some things need to still be addressed, but they should all be straightforward. Once resolved, should be ready for merge.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cfloorn $\color{red}253/257$
$\color{green}+98.44\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}253/257$
$\color{green}+98.44\%$
math/base/special/floorn $\color{red}269/272$
$\color{green}+98.90\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}269/272$
$\color{green}+98.90\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cfloorn $\color{green}257/257$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}257/257$
$\color{green}+100.00\%$
math/base/special/floorn $\color{green}272/272$
$\color{green}+100.00\%$
$\color{green}24/24$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}272/272$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once CI passes, will merge...

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cfloorn $\color{red}253/257$
$\color{green}+98.44\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}253/257$
$\color{green}+98.44\%$
math/base/special/floorn $\color{red}269/272$
$\color{green}+98.90\%$
$\color{green}23/23$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}269/272$
$\color{green}+98.90\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cfloorn $\color{green}257/257$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}257/257$
$\color{green}+100.00\%$
math/base/special/floorn $\color{green}272/272$
$\color{green}+100.00\%$
$\color{green}24/24$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}272/272$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte merged commit e627b29 into develop Sep 23, 2023
@kgryte kgryte deleted the cfloorn-addon branch September 23, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants