-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add native addon to floorn
and cfloorn
#1003
Conversation
BREAKING CHANGE: out keyword is no longer supported in cfloorn and now the function expects a double-precision complex-float number
BREAKING CHANGE: out keyword is no longer supported and now the API supports double-precision complex floating point numbers
cfloor
and cfloorn
floorn
and cfloorn
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/math/base/special/cfloorn/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/test/test.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/test/test.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/floorn/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/lib/native.js
Outdated
Show resolved
Hide resolved
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/math/base/special/cfloorn/manifest.json
Outdated
Show resolved
Hide resolved
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steff456 Overall this is looking good. Some things need to still be addressed, but they should all be straightforward. Once resolved, should be ready for merge.
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/math/base/special/cfloorn/lib/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cfloorn/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/floorn/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/floorn/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/floorn/manifest.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Once CI passes, will merge...
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Part of https://github.com/stdlib-js/todo/issues/1454
Description
This pull request:
For
floorn
API:For
cfloorn
API:Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers