Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor string package remove-first #1073

Merged
merged 9 commits into from
Aug 4, 2023
Merged

feat: refactor string package remove-first #1073

merged 9 commits into from
Aug 4, 2023

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Aug 1, 2023

Part of #1062

Description

What is the purpose of this pull request?

This pull request:

  • Refactors the string package @stdlib/string/remove-first
  • Adds @stdlib/string/base/remove-first
  • Adds @stdlib/string/base/remove-first-code-point
  • Adds @stdlib/string/base/remove-first-grapheme-cluster

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

  • The linter doesn't like the identifier name removeFirstGraphemeCluster because it exceeds 25 characters, should we supress this rule, or there's a shorter name we want to adopt for that package?

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Aug 2, 2023

@steff456 for removeFirstGraphemeCluster, just disable the line rule on a per line basis where the variable is first declared. E.g.,

var removeFirstGraphemeCluster = require( '<pkg>' ); // eslint-disable-line id-length

In Markdown, you'll need to add the following before each JavaScript block.

<!-- eslint-disable id-length -->

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @steff456!

@kgryte kgryte merged commit d1ded85 into develop Aug 4, 2023
@kgryte kgryte deleted the remove-first branch August 4, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants