Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add feature array/base/first #1169

Merged
merged 2 commits into from
Dec 9, 2023
Merged

feat: add feature array/base/first #1169

merged 2 commits into from
Dec 9, 2023

Conversation

Jaysukh-409
Copy link
Member

@Jaysukh-409 Jaysukh-409 commented Dec 9, 2023 •
edited by kgryte
Loading

Resolves #857 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds a new feature first for arrays

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Dec 9, 2023
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 9, 2023
@kgryte
Apply suggestions from code review
2cae288 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Jaysukh-409, for working on this! LGTM.

@kgryte
Copy link
Member

kgryte commented Dec 9, 2023

The failing job does not appear to be due to this commit. As such, will merge. Thanks again, @Jaysukh-409!

@kgryte kgryte merged commit 9d49231 into stdlib-js:develop Dec 9, 2023
6 of 7 checks passed
@Jaysukh-409 Jaysukh-409 deleted the first branch December 22, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/array/base/first
3 participants
@Jaysukh-409 @kgryte @stdlib-bot