-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update blas/ext/base/sapx
to follow current project conventions
#1824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
blas/ext/base/sapx
lib/node_modules/@stdlib/blas/ext/base/sapx/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapx/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @rxbryan. This PR is missing updated examples and is missing updated tests.
Thanks for the review @kgryte I will implement the changes ASAP |
Hi @kgryte I have pushed the requested changes. |
update blas/ext/base/sapx to follow current project conventions Fixes: stdlib-js#1152
Hi @kgryte Sorry for the excessive styling mistakes but they are all fixed now. I have updated the examples and tests |
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/blas/ext/base/sapx/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manifest.json
file needs to be updated. And just checking: there were no changes necessary for docs/repl.txt
or docs/types/index.d.ts
?
update manifest.json, docs/repl.txt
I've updated
|
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @rxbryan!
blas/ext/base/sapx
blas/ext/base/sapx
to follow current project conventions
update blas/ext/base/sapx to follow current project conventions
Description
updates blas/ext/base/sapx to follow current project conventions as outlined in issue #788
This pull request:
blas/ext/base/sapx
to follow current project conventions #1509Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers