Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/dssum to follow current projects conventions #1861

Merged
merged 2 commits into from
Mar 14, 2024
Merged

refactor: update blas/ext/base/dssum to follow current projects conventions #1861

merged 2 commits into from
Mar 14, 2024

Conversation

AuenKr
Copy link
Contributor

@AuenKr AuenKr commented Mar 13, 2024 •
edited
Loading

Resolves #1501 .

Description

What is the purpose of this pull request?

This pull request:

  • refactors @stdlib/blas/ext/base/dssum to follow current projects convention

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@AuenKr AuenKr changed the title refactor: update blas/ext/base/dssum to follow current projects conventions refactor: update blas/ext/base/dssum to follow current projects conventions Mar 13, 2024
@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 13, 2024

@Pranavchiku, can you review the PR?

@Pranavchiku
chore: apply suggestions from code review
06a99f2 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @AuenKr !

@Pranavchiku Pranavchiku added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 13, 2024
@Planeshifter Planeshifter merged commit fba1b9f into stdlib-js:develop Mar 14, 2024
7 checks passed
@AuenKr AuenKr deleted the refactor/dssum branch March 14, 2024 12:15
kgryte added a commit that referenced this pull request Mar 21, 2024
@kgryte
fix: update build configuration and remove unnecessary cast
fbb34de 
Ref: #1861
kgryte added a commit that referenced this pull request Mar 21, 2024
@kgryte
style: fix indentation
f25615d 
Ref: #1861
@AuenKr AuenKr mentioned this pull request Mar 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dssum to follow current project conventions
3 participants
@AuenKr @Pranavchiku @Planeshifter