Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update blas/ext/base/dsapxsum to follow current project conventions #1888

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

AuenKr
Copy link
Contributor

@AuenKr AuenKr commented Mar 14, 2024

Resolves #1489 .

Description

What is the purpose of this pull request?

This pull request:

  • refactors @stdlib/blas/ext/base/dsapxsum to follow current projects convention

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 14, 2024

@Pranavchiku, can you review the PR?

@AuenKr AuenKr marked this pull request as draft March 14, 2024 16:43
@AuenKr AuenKr marked this pull request as ready for review March 14, 2024 16:55
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 15, 2024
@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 21, 2024

@kgryte, applied all changes suggested in other PR.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just fixed a copy-paste error; will merge after CI checks passed.

@Planeshifter Planeshifter merged commit 6f75d45 into stdlib-js:develop Mar 21, 2024
8 checks passed
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dsapxsum to follow current project conventions
4 participants