-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update blas/ext/base/dsapxsum
to follow current project conventions
#1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Pranavchiku, can you review the PR? |
stdlib-bot
added
the
BLAS
Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
label
Mar 15, 2024
1 task
@kgryte, applied all changes suggested in other PR. |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just fixed a copy-paste error; will merge after CI checks passed.
kgryte
added
Enhancement
Issue or pull request for enhancing existing functionality.
Native Addons
Issue involves or relates to Node.js native add-ons.
C
Issue involves or relates to C.
labels
Mar 22, 2024
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BLAS
Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
C
Issue involves or relates to C.
Enhancement
Issue or pull request for enhancing existing functionality.
Native Addons
Issue involves or relates to Node.js native add-ons.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1489 .
Description
This pull request:
@stdlib/blas/ext/base/dsapxsum
to follow current projects conventionRelated Issues
This pull request:
blas/ext/base/dsapxsum
to follow current project conventions #1489Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers