Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/scusumpw to follow current project conventions #1929

Merged
merged 4 commits into from
Mar 21, 2024
Merged

refactor: update blas/ext/base/scusumpw to follow current project conventions #1929

merged 4 commits into from
Mar 21, 2024

Conversation

rxbryan
Copy link
Contributor

@rxbryan rxbryan commented Mar 17, 2024

updates blas/ext/base/scusumpw to follow current project conventions

Related Issues

Does this pull request have any related issues?
Yes
Issue #788
Issue #1152

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@rxbryan
refactor: update blas/ext/base/scusumpw
3683d51 
updates blas/ext/base/scusumpw to follow current project conventions

Fixes: stdlib-js#1520
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 17, 2024
@Pranavchiku
chore: apply suggestions from code review
260a90f 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @rxbryan !

@Pranavchiku Pranavchiku added C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 17, 2024
@rxbryan
Copy link
Contributor Author

rxbryan commented Mar 20, 2024

Hi @Pranavchiku. whats the status of the pr?

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. and removed Ready To Merge A pull request which is ready to be merged. labels Mar 21, 2024
@kgryte kgryte self-requested a review March 21, 2024 01:07
@Planeshifter
Apply suggestions from code review
d68f78a 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Will merge once CI passes after a few final changes.

@Planeshifter
Update manifest.json
a7a1d39 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter changed the title feat: refactor blas/ext/base/scusumpw to follow current project conventions refactor: update blas/ext/base/scusumpw to follow current project conventions Mar 21, 2024
@Planeshifter Planeshifter merged commit f95e706 into stdlib-js:develop Mar 21, 2024
8 checks passed
kgryte added a commit that referenced this pull request Mar 21, 2024
@kgryte
fix: update build configuration
4d9c326 
Ref: #1929
@rxbryan rxbryan mentioned this pull request Mar 26, 2024
Closed
6 tasks
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

@Planeshifter Planeshifter Planeshifter approved these changes

@kgryte kgryte Awaiting requested review from kgryte

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/scusumpw to follow current project conventions
5 participants
@rxbryan @Planeshifter @Pranavchiku @kgryte @stdlib-bot