Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation of math/base/special/fast/alpha-max-plus-beta-min #1947

Merged
merged 16 commits into from
Mar 23, 2024
Merged

feat: add C implementation of math/base/special/fast/alpha-max-plus-beta-min #1947

merged 16 commits into from
Mar 23, 2024

Conversation

USERSATOSHI
Copy link
Contributor

@USERSATOSHI USERSATOSHI commented Mar 18, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for math/base/special/fast/alpha-max-plus-beta-min

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 18, 2024
stdlib-bot
stdlib-bot reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@USERSATOSHI USERSATOSHI mentioned this pull request Mar 18, 2024
Closed
14 tasks
@USERSATOSHI
Copy link
Contributor Author

I think pr Is ready for review

@USERSATOSHI USERSATOSHI changed the title feat(math): c implementation of alpha-max-plus-beta-min feat(math): c implementation of alpha-max-plus-beta-min Mar 18, 2024
@Pranavchiku Pranavchiku changed the title feat(math): c implementation of alpha-max-plus-beta-min feat: add C implementation of math/base/special/fast/alpha-max-plus-beta-min Mar 19, 2024
Pranavchiku
Pranavchiku suggested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes, please ping once you are done with those. Thanks for your contributions!

...odules/@stdlib/math/base/special/fast/alpha-max-plus-beta-min/benchmark/c/native/benchmark.c Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/alpha-max-plus-beta-min/examples/c/example.c Outdated Show resolved Hide resolved
...fast/alpha-max-plus-beta-min/include/stdlib/math/base/special/fast/alpha-max-plus-beta-min.h Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/alpha-max-plus-beta-min/src/addon.c Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/alpha-max-plus-beta-min/src/main.c Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/alpha-max-plus-beta-min/src/main.c Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/alpha-max-plus-beta-min/test/test.native.js Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/alpha-max-plus-beta-min/test/test.native.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/alpha-max-plus-beta-min/test/test.native.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/fast/alpha-max-plus-beta-min/README.md Outdated Show resolved Hide resolved
@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 19, 2024
@USERSATOSHI
Copy link
Contributor Author

@Pranavchiku Hi, I have updated as stated in review , can you please review it

@USERSATOSHI
Copy link
Contributor Author

USERSATOSHI commented Mar 19, 2024 •
edited
Loading

sorry, i missed readme.md
I have checked abs's readme as well as current ampbm's readme on github
I have updated the readme as stated

@USERSATOSHI USERSATOSHI requested a review from Pranavchiku March 20, 2024 00:24
@USERSATOSHI
Copy link
Contributor Author

USERSATOSHI commented Mar 20, 2024 •
edited
Loading

@Pranavchiku if you are free, can you re-review it

kgryte
kgryte requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @USERSATOSHI. Left an initial set of comments.

@kgryte
Copy link
Member

kgryte commented Mar 21, 2024

Looks also like CI is failing for this PR.

@USERSATOSHI
Copy link
Contributor Author

Looks also like CI is failing for this PR.

I forgot to update includes in benchmark , thanks for informing that and right now I updating the styles according the suggestion

@USERSATOSHI USERSATOSHI requested a review from kgryte March 21, 2024 21:45
@kgryte
Apply suggestions from code review
d6d8342 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
1535595 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
5b9be64 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
cc4725b 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte added 2 commits March 23, 2024 00:35
@kgryte
Apply suggestions from code review
4303c88 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
73c86ff 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
0245217 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @USERSATOSHI!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 23, 2024
@kgryte kgryte merged commit abf4652 into stdlib-js:develop Mar 23, 2024
8 checks passed
@USERSATOSHI USERSATOSHI mentioned this pull request Mar 25, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@kgryte kgryte kgryte approved these changes

@Pranavchiku Pranavchiku Awaiting requested review from Pranavchiku

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for @stdlib/math/base/special/fast/alpha-max-plus-beta-min
4 participants
@USERSATOSHI @kgryte @stdlib-bot @Pranavchiku