refactor: update blas/ext/base/scusumkbn2 to follow current project conventions
#1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
kgryte
added
Enhancement
kgryte
changed the title
blas/ext/base/scusumkbn2 to follow current project conventionsblas/ext/base/scusumkbn2 to follow current project conventions
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/benchmark/c/benchmark.length.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/benchmark/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/test/test.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/test/test.scusumkbn2.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/test/test.scusumkbn2.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/docs/types/test.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/examples/c/Makefile
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/include/stdlib/blas/ext/base/scusumkbn2.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/src/scusumkbn2.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/test/test.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/lib/scusumkbn2.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/lib/scusumkbn2.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/scusumkbn2/lib/ndarray.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
requested changes
Mar 22, 2024
There was a problem hiding this comment.
This looks overall very good. Thank you for working on it!
Notice I had to revert the copyright year changes: It is our convention to not update them when files are edited, only when they are first committed to the repository.
One thing: Please edit the manifest.json file to be 2-space indented and to have benchmark and example configurations.
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
|
@Planeshifter I've added the suggested changes, please check. |
Planeshifter
approved these changes
Mar 23, 2024
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1518
Description
This pull request:
blas/ext/base/scusumkbn2to follow current project conventionsRelated Issues
This pull request:
blas/ext/base/scusumkbn2to follow current project conventions #1518Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers