Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/zswap #2075

Merged
merged 13 commits into from
Apr 3, 2024
Merged

feat: add blas/base/zswap #2075

merged 13 commits into from
Apr 3, 2024

Conversation

performant23
Copy link
Contributor

If applied, this commit will add the package blas/base/zswap

Description

What is the purpose of this pull request?
Add the package blas/base/zswap

This pull request:

  • includes the support for C and Fortran and obtains Fortran reference from this page

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@performant23
feat: add blas/base/zswap
5bce9c2 
If applied, this commit will add the package `blas/base/zswap`
@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 27, 2024
@performant23
Copy link
Contributor Author

Refactoring the code to use real instead of realf as reviewed in blas/base/zcopy, will reopen once done.

@performant23 performant23 reopened this Mar 27, 2024
@kgryte
Copy link
Member

kgryte commented Apr 3, 2024

@performant23 Looks like you are missing the Makefile for the /src directory.

@kgryte
Apply suggestions from code review
ec4a30f 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Copy link
Member

kgryte commented Apr 3, 2024

/stdlib update-copyright-years

@kgryte
Apply suggestions from code review
0df2c4b 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
1ba9fce 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
1dc664d 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
182f821 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
0c0e655 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @performant23!

@kgryte
Copy link
Member

kgryte commented Apr 3, 2024

Ah, wait. You need to add the missing Makefile before we can merge.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Apr 3, 2024
@performant23
Copy link
Contributor Author

performant23 commented Apr 3, 2024 •
edited
Loading

Ah, wait. You need to add the missing Makefile before we can merge.

Added, thank you so much for your review!

Edit: Ah, some tests are failing, working on the fix

Hmm, that's strange. everything seems to work locally
image

@kgryte
Copy link
Member

kgryte commented Apr 3, 2024

@performant23 As you are on Windows, you were testing against the C implementation which did not have any issues. However, the Fortran implementation did have bugs, and the Fortran implementation was what was being tested against in CI. The issues should now be addressed.

kgryte
kgryte approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks, @performant23! I'll merge once CI passes.

@kgryte kgryte merged commit 7155e52 into stdlib-js:develop Apr 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/base/zswap
3 participants
@performant23 @kgryte @stdlib-bot