Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blas/base/cscal #2104

Merged
merged 49 commits into from
Jun 8, 2024
Merged

feat: add blas/base/cscal #2104

merged 49 commits into from
Jun 8, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Apr 1, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This RFC proposes to add a routine to scale values of input complex single-precision floating-point vector by another complex single-precision floating-point constant vector as defined in BLAS Level 1 routines. Specifically adding @stdlib/blas/base/cscal is proposed.

Related Issues

Does this pull request have any related issues?
None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aman-095
Copy link
Member Author

aman-095 commented Apr 1, 2024

@kgryte @Pranavchiku benchmarks for this routine are failing, don't know why NaN is coming in output. Can you please review it once?

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Apr 1, 2024
kgryte
kgryte requested changes Apr 1, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-095 Thanks for working on this. Left some comments. This needs a fairly heavy refactor given the misunderstanding around ca.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Apr 1, 2024
@aman-095
Copy link
Member Author

aman-095 commented Apr 1, 2024

Sure @kgryte will work on this and resolve the issues.

@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label May 23, 2024
kgryte added 20 commits June 8, 2024 15:04
@kgryte
Merge branch 'develop' of https://github.com/stdlib-js/stdlib into pr…
6223d2a 
…/aman-095/2104
@kgryte
bench: fix benchmarks
40b6db9
@kgryte
bench: refactor array creation
b1acc24
@kgryte
docs: update require paths
a517b6e
@kgryte
fix: update paths and fix text wrapping
8a57432
@kgryte
docs: update comment
c553c34
@kgryte
docs: fix require path
0b49f7f
@kgryte
fix: update function signatures to indicate that argument is mutated
dc90750
@kgryte
docs: update require paths
8419e12
@kgryte
refactor: lowercase variable name
26d9489
@kgryte
refactor: remove duplicate loops
2201653
@kgryte
docs: add missing note
e188d27
@kgryte
fix: update signatures
68cbef3
@kgryte
build: fix dependencies
08cb3cc
@kgryte
chore: remove keyword
7980f53
@kgryte
docs: update require paths
b125ed1
@kgryte
test: update require paths and remove duplicate tests
c2a2fdb
@kgryte
docs: add C interface documentation
24fe831
@kgryte
refactor: add support for 64-bit integers
bba0e36
@kgryte
bench: fix overflow
d307934
@kgryte kgryte removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jun 8, 2024
kgryte
kgryte approved these changes Jun 8, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored and updated to support 64-bit integers. This should now be ready to merge. @aman-095 You'll want to update #2253 accordingly.

@kgryte kgryte merged commit b40f5c3 into stdlib-js:develop Jun 8, 2024
8 checks passed
aman-095 added a commit to aman-095/stdlib that referenced this pull request Jun 13, 2024
@aman-095 @kgryte
feat: add blas/base/cscal
d11f851 
PR-URL: stdlib-js#2104
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aman-095 @kgryte @Planeshifter @stdlib-bot