Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove explicit cast and update function parameter description in blas/ext/base/drev #3127

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

headlessNode
Copy link
Member

@headlessNode headlessNode commented Nov 17, 2024

Description

What is the purpose of this pull request?

This pull request:

  • removes explicit casting of the input array in the addon.c file
  • update function parameter description in the README.md file
  • fix spacing around parenthesis drev.js file
  • rearrange variable declarations in the main.c file

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 17, 2024
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

Coverage Report

No coverage information available.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @headlessNode!

@kgryte
Copy link
Member

kgryte commented Nov 17, 2024

CI failing is not due to issues with this PR, but due to an erring cppcheck. As such, will go ahead and merge.

@kgryte kgryte merged commit cb425f9 into stdlib-js:develop Nov 17, 2024
26 of 29 checks passed
@headlessNode headlessNode deleted the refactor-drev branch November 19, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants