Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/dsort2hp #3292

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

feat: add C ndarray API and refactor blas/ext/base/dsort2hp #3292

wants to merge 11 commits into from

Conversation

headlessNode
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • add C ndarray API and refactor/cleanup blas/ext/base/dsort2hp

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Nov 28, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 28, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dsort2hp $\color{green}516/516$
$\color{green}+100.00\%$ 		$\color{green}36/36$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}516/516$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@headlessNode
fix: apply review suggestions
dc519ed 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@headlessNode
docs: apply review suggestion
fa616a3 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@headlessNode
docs: apply review suggestion
e53859d 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@headlessNode
docs: apply review suggestion
c9f0e61 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Nov 28, 2024
@headlessNode
docs: apply review suggestion
ebfe4fa 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@headlessNode
docs: apply review suggestion
e7e26af 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@headlessNode
refactor: apply review suggestion
add5315 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@headlessNode
refactor: apply review suggestion
807d7c9 
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
headlessNode
headlessNode commented Nov 29, 2024
View reviewed changes
lib/node_modules/@stdlib/blas/ext/base/dsort2hp/examples/c/example.c
Comment on lines 38 to 42
for ( int i = 0; i < 8; i++ ) {
printf( "x[ %i ] = %lf\n", i, x[ i ] );
printf( "y[ %i ] = %"PRId64"\n", i, (int64_t)y[ i ] );
printf( "y[ %i ] = %lf\n", i, y[ i ] );
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgryte I'm not sure, if this change is okay?

@headlessNode headlessNode marked this pull request as ready for review November 29, 2024 08:27
@headlessNode
Copy link
Member Author

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 29, 2024
@stdlib-bot
Copy link
Contributor

@headlessNode, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 29, 2024
@headlessNode headlessNode marked this pull request as draft November 29, 2024 15:53
@headlessNode
Copy link
Member Author

headlessNode commented Nov 29, 2024 •
edited
Loading

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 29, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 29, 2024
@headlessNode headlessNode marked this pull request as ready for review November 29, 2024 16:44
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Dec 8, 2024
@Planeshifter Planeshifter requested a review from kgryte December 8, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte Awaiting requested review from kgryte

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @stdlib-bot @Planeshifter